Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-06 Thread Shawn Guo
On Thu, Nov 07, 2013 at 03:32:09AM +, Rongjun Ying wrote: > I think my patch is better. Well, unfortunately your patch is plainly wrong, because there are in-tree users of voltage-tolerance right now. How can you simply remove it from driver with ignoring these users? $ git grep

RE: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-06 Thread Rongjun Ying
Song > Subject: Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage > instead of voltage-tolerance > > On Thu, Nov 07, 2013 at 01:55:21AM +, Rongjun Ying wrote: > > > For given board, what voltages could be provided is known. So you > > > can just

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-06 Thread Shawn Guo
On Thu, Nov 07, 2013 at 01:55:21AM +, Rongjun Ying wrote: > > For given board, what voltages could be provided is known. So you can > > just define OPP table in .dts and specify the voltage as the > > value that the regulator IC can supply, e.g. 1.200V in above example. > > > > This is not

RE: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-06 Thread Rongjun Ying
rongjun.y...@gcsr.com > Subject: Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage > instead of voltage-tolerance > > On Wed, Nov 06, 2013 at 02:15:07AM +, Rongjun Ying wrote: > > If omit voltage-tolerance, sometimes also can't get appropriate > voltages. > &g

RE: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-06 Thread Rongjun Ying
: Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance On Wed, Nov 06, 2013 at 02:15:07AM +, Rongjun Ying wrote: If omit voltage-tolerance, sometimes also can't get appropriate voltages. For example: If the regulator IC only can supply min voltage

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-06 Thread Shawn Guo
On Thu, Nov 07, 2013 at 01:55:21AM +, Rongjun Ying wrote: For given board, what voltages could be provided is known. So you can just define OPP table in board.dts and specify the voltage as the value that the regulator IC can supply, e.g. 1.200V in above example. This is not nice,

RE: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-06 Thread Rongjun Ying
/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance On Thu, Nov 07, 2013 at 01:55:21AM +, Rongjun Ying wrote: For given board, what voltages could be provided is known. So you can just define OPP table in board.dts and specify the voltage as the value

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-06 Thread Shawn Guo
On Thu, Nov 07, 2013 at 03:32:09AM +, Rongjun Ying wrote: I think my patch is better. Well, unfortunately your patch is plainly wrong, because there are in-tree users of voltage-tolerance right now. How can you simply remove it from driver with ignoring these users? $ git grep

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-05 Thread Shawn Guo
On Wed, Nov 06, 2013 at 02:15:07AM +, Rongjun Ying wrote: > If omit voltage-tolerance, sometimes also can't get appropriate voltages. > For example: > If the regulator IC only can supply min voltage is 1.000V and max voltage is > 1.200V, and cpu work max voltage is 1.200V. > But the cpu just

RE: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-05 Thread Rongjun Ying
om; > Rongjun Ying > Subject: Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage > instead of voltage-tolerance > > On Tue, Nov 05, 2013 at 10:08:06AM +0530, Viresh Kumar wrote: > > Adding shawn in cc list.. > > > > On 5 November 2013 08:40, rjying wr

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-05 Thread Shawn Guo
On Tue, Nov 05, 2013 at 10:08:06AM +0530, Viresh Kumar wrote: > Adding shawn in cc list.. > > On 5 November 2013 08:40, rjying wrote: > > From: Rongjun Ying > > > > Sometime the regulator can't supply appropriate voltages for requestion of > > cpu. > > All voltage tolerance value can't figure

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-05 Thread Shawn Guo
On Tue, Nov 05, 2013 at 10:08:06AM +0530, Viresh Kumar wrote: Adding shawn in cc list.. On 5 November 2013 08:40, rjying rjy...@gmail.com wrote: From: Rongjun Ying rongjun.y...@csr.com Sometime the regulator can't supply appropriate voltages for requestion of cpu. All voltage

RE: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-05 Thread Rongjun Ying
: Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance On Tue, Nov 05, 2013 at 10:08:06AM +0530, Viresh Kumar wrote: Adding shawn in cc list.. On 5 November 2013 08:40, rjying rjy...@gmail.com wrote: From: Rongjun Ying rongjun.y...@csr.com Sometime

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-05 Thread Shawn Guo
On Wed, Nov 06, 2013 at 02:15:07AM +, Rongjun Ying wrote: If omit voltage-tolerance, sometimes also can't get appropriate voltages. For example: If the regulator IC only can supply min voltage is 1.000V and max voltage is 1.200V, and cpu work max voltage is 1.200V. But the cpu just need

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-04 Thread Viresh Kumar
Adding shawn in cc list.. On 5 November 2013 08:40, rjying wrote: > From: Rongjun Ying > > Sometime the regulator can't supply appropriate voltages for requestion of > cpu. > All voltage tolerance value can't figure out a good voltage. > > Signed-off-by: Rongjun Ying > --- >

[PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-04 Thread rjying
From: Rongjun Ying Sometime the regulator can't supply appropriate voltages for requestion of cpu. All voltage tolerance value can't figure out a good voltage. Signed-off-by: Rongjun Ying --- drivers/cpufreq/cpufreq-cpu0.c | 17 ++--- 1 files changed, 10 insertions(+), 7

[PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-04 Thread rjying
From: Rongjun Ying rongjun.y...@csr.com Sometime the regulator can't supply appropriate voltages for requestion of cpu. All voltage tolerance value can't figure out a good voltage. Signed-off-by: Rongjun Ying rongjun.y...@csr.com --- drivers/cpufreq/cpufreq-cpu0.c | 17 ++--- 1

Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance

2013-11-04 Thread Viresh Kumar
Adding shawn in cc list.. On 5 November 2013 08:40, rjying rjy...@gmail.com wrote: From: Rongjun Ying rongjun.y...@csr.com Sometime the regulator can't supply appropriate voltages for requestion of cpu. All voltage tolerance value can't figure out a good voltage. Signed-off-by: Rongjun