Re: [PATCH 1/1] do not abuse ->cred_guard_mutex in threadgroup_lock()

2013-03-10 Thread Li Zefan
On 2013/3/10 4:01, Oleg Nesterov wrote: > threadgroup_lock() takes signal->cred_guard_mutex to ensure that > thread_group_leader() is stable. This doesn't look nice, the scope > of this lock in do_execve() is huge. > > And as Dave pointed out this can lead to deadlock, we have the > following

Re: [PATCH 1/1] do not abuse -cred_guard_mutex in threadgroup_lock()

2013-03-10 Thread Li Zefan
On 2013/3/10 4:01, Oleg Nesterov wrote: threadgroup_lock() takes signal-cred_guard_mutex to ensure that thread_group_leader() is stable. This doesn't look nice, the scope of this lock in do_execve() is huge. And as Dave pointed out this can lead to deadlock, we have the following

Re: [PATCH 1/1] do not abuse ->cred_guard_mutex in threadgroup_lock()

2013-03-09 Thread Tejun Heo
On Sat, Mar 9, 2013 at 12:01 PM, Oleg Nesterov wrote: > threadgroup_lock() takes signal->cred_guard_mutex to ensure that > thread_group_leader() is stable. This doesn't look nice, the scope > of this lock in do_execve() is huge. > > And as Dave pointed out this can lead to deadlock, we have the >

[PATCH 1/1] do not abuse ->cred_guard_mutex in threadgroup_lock()

2013-03-09 Thread Oleg Nesterov
threadgroup_lock() takes signal->cred_guard_mutex to ensure that thread_group_leader() is stable. This doesn't look nice, the scope of this lock in do_execve() is huge. And as Dave pointed out this can lead to deadlock, we have the following dependencies: do_execve:

[PATCH 1/1] do not abuse -cred_guard_mutex in threadgroup_lock()

2013-03-09 Thread Oleg Nesterov
threadgroup_lock() takes signal-cred_guard_mutex to ensure that thread_group_leader() is stable. This doesn't look nice, the scope of this lock in do_execve() is huge. And as Dave pointed out this can lead to deadlock, we have the following dependencies: do_execve:

Re: [PATCH 1/1] do not abuse -cred_guard_mutex in threadgroup_lock()

2013-03-09 Thread Tejun Heo
On Sat, Mar 9, 2013 at 12:01 PM, Oleg Nesterov o...@redhat.com wrote: threadgroup_lock() takes signal-cred_guard_mutex to ensure that thread_group_leader() is stable. This doesn't look nice, the scope of this lock in do_execve() is huge. And as Dave pointed out this can lead to deadlock, we