Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Rab, 2017-03-01 at 12:34 +0100, Arnd Bergmann wrote: > On Wed, Mar 1, 2017 at 11:42 AM, Loh, Tien Hock com> wrote: > > > > On Rab, 2017-03-01 at 10:01 +0100, Arnd Bergmann wrote: > > > > > > On Wed, Mar 1, 2017 at 8:23 AM, Loh, Tien Hock > > el.c >

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Rab, 2017-03-01 at 12:34 +0100, Arnd Bergmann wrote: > On Wed, Mar 1, 2017 at 11:42 AM, Loh, Tien Hock com> wrote: > > > > On Rab, 2017-03-01 at 10:01 +0100, Arnd Bergmann wrote: > > > > > > On Wed, Mar 1, 2017 at 8:23 AM, Loh, Tien Hock > > el.c > > > Another option would be to fold the

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Wed, Mar 1, 2017 at 11:42 AM, Loh, Tien Hock wrote: > On Rab, 2017-03-01 at 10:01 +0100, Arnd Bergmann wrote: >> On Wed, Mar 1, 2017 at 8:23 AM, Loh, Tien Hock > Another option would be to fold the timestamp into the revision >> attribute, >>

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Wed, Mar 1, 2017 at 11:42 AM, Loh, Tien Hock wrote: > On Rab, 2017-03-01 at 10:01 +0100, Arnd Bergmann wrote: >> On Wed, Mar 1, 2017 at 8:23 AM, Loh, Tien Hock > Another option would be to fold the timestamp into the revision >> attribute, >> but whether that is a reasonable place for it would

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Rab, 2017-03-01 at 10:01 +0100, Arnd Bergmann wrote: > On Wed, Mar 1, 2017 at 8:23 AM, Loh, Tien Hock om> wrote: > > > > Arnd, Greg, > Please don't top-post. OK. > > > > > I checked the attributes returned by the soc attribute subsystem, > > but > > it seems that it

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Rab, 2017-03-01 at 10:01 +0100, Arnd Bergmann wrote: > On Wed, Mar 1, 2017 at 8:23 AM, Loh, Tien Hock om> wrote: > > > > Arnd, Greg, > Please don't top-post. OK. > > > > > I checked the attributes returned by the soc attribute subsystem, > > but > > it seems that it is lacking something

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Wed, Mar 1, 2017 at 8:23 AM, Loh, Tien Hock wrote: > Arnd, Greg, Please don't top-post. > I checked the attributes returned by the soc attribute subsystem, but > it seems that it is lacking something equivalent to timestamp in the > Intel System ID controller. Do you

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Wed, Mar 1, 2017 at 8:23 AM, Loh, Tien Hock wrote: > Arnd, Greg, Please don't top-post. > I checked the attributes returned by the soc attribute subsystem, but > it seems that it is lacking something equivalent to timestamp in the > Intel System ID controller. Do you think it is better to

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

Arnd, Greg, I checked the attributes returned by the soc attribute subsystem, but it seems that it is lacking something equivalent to timestamp in the Intel System ID controller. Do you think it is better to add a new attribute (named timestamp) to soc or create a new sysfs entry like what I did?

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

Arnd, Greg, I checked the attributes returned by the soc attribute subsystem, but it seems that it is lacking something equivalent to timestamp in the Intel System ID controller. Do you think it is better to add a new attribute (named timestamp) to soc or create a new sysfs entry like what I did?

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

OK then I'll move it into driver/soc/ in that case. On Kha, 2017-02-23 at 09:05 +0100, Arnd Bergmann wrote: > On Thu, Feb 23, 2017 at 6:58 AM, Loh, Tien Hock com> wrote: > > > > On Rab, 2017-02-15 at 20:51 +0100, Arnd Bergmann wrote: > > > > > > On Wed, Feb 15, 2017 at

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

OK then I'll move it into driver/soc/ in that case. On Kha, 2017-02-23 at 09:05 +0100, Arnd Bergmann wrote: > On Thu, Feb 23, 2017 at 6:58 AM, Loh, Tien Hock com> wrote: > > > > On Rab, 2017-02-15 at 20:51 +0100, Arnd Bergmann wrote: > > > > > > On Wed, Feb 15, 2017 at 6:17 PM, Greg KH > >

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Thu, Feb 23, 2017 at 6:58 AM, Loh, Tien Hock wrote: > On Rab, 2017-02-15 at 20:51 +0100, Arnd Bergmann wrote: >> On Wed, Feb 15, 2017 at 6:17 PM, Greg KH >> wrote: >> > >> > On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote: >> > > >> >

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Thu, Feb 23, 2017 at 6:58 AM, Loh, Tien Hock wrote: > On Rab, 2017-02-15 at 20:51 +0100, Arnd Bergmann wrote: >> On Wed, Feb 15, 2017 at 6:17 PM, Greg KH >> wrote: >> > >> > On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote: >> > > >> > > From: "Loh, Tien Hock" >> > > >> > > This patch

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

Sorry for the late reply.  This driver can currently be used by ARM and Nios II, so moving it into drivers/soc might not be the best idea. Thanks Tien Hock On Rab, 2017-02-15 at 20:51 +0100, Arnd Bergmann wrote: > On Wed, Feb 15, 2017 at 6:17 PM, Greg KH > wrote: > >

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

Sorry for the late reply.  This driver can currently be used by ARM and Nios II, so moving it into drivers/soc might not be the best idea. Thanks Tien Hock On Rab, 2017-02-15 at 20:51 +0100, Arnd Bergmann wrote: > On Wed, Feb 15, 2017 at 6:17 PM, Greg KH > wrote: > > > > On Wed, Feb 15, 2017

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

Sorry for the late reply. I'll add the Documentation/ABI description, use DEVICE_ATTR_RO and update ATTRIBUTE_GROUP.  Thanks Tien Hock On Rab, 2017-02-15 at 09:17 -0800, Greg KH wrote: > On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote: > > > > From: "Loh, Tien Hock"

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

Sorry for the late reply. I'll add the Documentation/ABI description, use DEVICE_ATTR_RO and update ATTRIBUTE_GROUP.  Thanks Tien Hock On Rab, 2017-02-15 at 09:17 -0800, Greg KH wrote: > On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote: > > > > From: "Loh, Tien Hock" > > > > This patch

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Wed, Feb 15, 2017 at 6:17 PM, Greg KH wrote: > On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote: >> From: "Loh, Tien Hock" >> >> This patch is to add Altera System ID driver. >> User can obtain the system ID and timestamp of the system

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Wed, Feb 15, 2017 at 6:17 PM, Greg KH wrote: > On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote: >> From: "Loh, Tien Hock" >> >> This patch is to add Altera System ID driver. >> User can obtain the system ID and timestamp of the system by >> reading the sysfs entry. >> >> Usage: >> cat

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote: > From: "Loh, Tien Hock" > > This patch is to add Altera System ID driver. > User can obtain the system ID and timestamp of the system by > reading the sysfs entry. > > Usage: > cat

Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver

On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote: > From: "Loh, Tien Hock" > > This patch is to add Altera System ID driver. > User can obtain the system ID and timestamp of the system by > reading the sysfs entry. > > Usage: > cat /sys/bus/platform/devices/[addr].sysid/sysid/id > cat