Re: [PATCH 1/1] drivers/rtc/rtc-bq32k.c: remove redundant check

2015-07-14 Thread Alexandre Belloni
Hi, On 08/07/2015 at 12:26:47 +0530, Maninder Singh wrote : > removing below static analysis error:- What tool did you use? > (error) Possible null pointer dereference: client > > if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) >

[PATCH 1/1] drivers/rtc/rtc-bq32k.c: remove redundant check

2015-07-07 Thread Maninder Singh
removing below static analysis error:- (error) Possible null pointer dereference: client if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) ^^^ Error comes beacause client is dereferenced before NULL check. So probabily NULL thi