Re: [PATCH 1/1] drivers/staging/pi433: New driver (fwd)

2017-07-16 Thread Marcus Wolf
Hi Julia, thank you very much for your investigation! I totally agree - on line 894 device->dev must not be used. Any suggestions? Is there a kind of generic value, I can pass as first argument of dev_dbg() in such cases? Or switch to printk()? Regarding second bug: line 688 modified as follows:

Re: [PATCH 1/1] drivers/staging/pi433: New driver (fwd)

2017-07-15 Thread Julia Lawall
Please check on lines 894 and 688 (not shown) for the issues mentioned below. Note that the ifs and {s in the following code snippet don't always follow the kernel coding style, eg on line 901. julia -- Forwarded message -- Date: Sun, 16 Jul 2017 04:35:49 +0800 From: kbuild test