Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-04-17 Thread Chewie Lin
On Tue, Apr 18, 2017 at 06:14:11AM +0200, Greg KH wrote: > On Mon, Apr 17, 2017 at 04:58:48PM -0700, Chewie Lin wrote: > > Swap string in the dev_warn() call with __func__ argument, instead of > > explicitly calling the function name in the string: > > > > WARNING: Prefer using "%s",

Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-04-17 Thread Chewie Lin
On Tue, Apr 18, 2017 at 06:14:11AM +0200, Greg KH wrote: > On Mon, Apr 17, 2017 at 04:58:48PM -0700, Chewie Lin wrote: > > Swap string in the dev_warn() call with __func__ argument, instead of > > explicitly calling the function name in the string: > > > > WARNING: Prefer using "%s",

Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-04-17 Thread Greg KH
On Mon, Apr 17, 2017 at 04:58:48PM -0700, Chewie Lin wrote: > Swap string in the dev_warn() call with __func__ argument, instead of > explicitly calling the function name in the string: > > WARNING: Prefer using "%s", __func__ to embedded function names > #417: FILE:

Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-04-17 Thread Greg KH
On Mon, Apr 17, 2017 at 04:58:48PM -0700, Chewie Lin wrote: > Swap string in the dev_warn() call with __func__ argument, instead of > explicitly calling the function name in the string: > > WARNING: Prefer using "%s", __func__ to embedded function names > #417: FILE:

[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-04-17 Thread Chewie Lin
Swap string in the dev_warn() call with __func__ argument, instead of explicitly calling the function name in the string: WARNING: Prefer using "%s", __func__ to embedded function names #417: FILE: main_usb.c:417: +"usb_device_reset fail

[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-04-17 Thread Chewie Lin
Swap string in the dev_warn() call with __func__ argument, instead of explicitly calling the function name in the string: WARNING: Prefer using "%s", __func__ to embedded function names #417: FILE: main_usb.c:417: +"usb_device_reset fail

Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Greg KH
On Fri, Mar 31, 2017 at 03:01:12AM -0700, Chewie Lin wrote: > fix a checkpatch warning: > WARNING: Prefer using "%s", __func__ to embedded function names > > Signed-off-by: Chewie Lin > --- > drivers/staging/vt6656/main_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Greg KH
On Fri, Mar 31, 2017 at 03:01:12AM -0700, Chewie Lin wrote: > fix a checkpatch warning: > WARNING: Prefer using "%s", __func__ to embedded function names > > Signed-off-by: Chewie Lin > --- > drivers/staging/vt6656/main_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Kim Phillips
On Fri, 31 Mar 2017 03:01:12 -0700 Chewie Lin wrote: > fix a checkpatch warning: > WARNING: Prefer using "%s", __func__ to embedded function names __func__, so: > - "usb_device_reset fail status=%d\n", status); > + "%s=%d\n",

Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Kim Phillips
On Fri, 31 Mar 2017 03:01:12 -0700 Chewie Lin wrote: > fix a checkpatch warning: > WARNING: Prefer using "%s", __func__ to embedded function names __func__, so: > - "usb_device_reset fail status=%d\n", status); > + "%s=%d\n", "usb_device_reset fail

[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Chewie Lin
fix a checkpatch warning: WARNING: Prefer using "%s", __func__ to embedded function names Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c

[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Chewie Lin
fix a checkpatch warning: WARNING: Prefer using "%s", __func__ to embedded function names Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c