Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

At least one source has reported that vmwgfx_fb.c::vmw_fb_check_var() is not even a code path that is traversed when the bug occurs (i.e. inserted unique log message -> never seen in logs). Also, everyone encountering the bug seems to be on a slightly older version of VMWare Player. It does not se

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

On 07/02/2014 05:01 AM, Christopher Friedt wrote: > I have been unable to reproduce this issue in a plethora of test > cases, although granted, I do not have access to a Win7 machine. For > that, I have asked an Ubuntu tester to run through some tests for me. > > https://urldefense.proofpoint.com/v

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

I have been unable to reproduce this issue in a plethora of test cases, although granted, I do not have access to a Win7 machine. For that, I have asked an Ubuntu tester to run through some tests for me. https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-vmware/+bug/1328898/comments/8 W

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

On 06/30/2014 03:18 PM, Christopher Friedt wrote: > On Mon, Jun 30, 2014 at 8:49 AM, Christopher Friedt > wrote: >> That sounds a bit more accurate. Should kms and fbdev be setting both >> registers then? > I wonder if fbdev can use PITCHLOCK as well, rather than > BYTES_PER_LINE. I will only be a

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

On Mon, Jun 30, 2014 at 8:49 AM, Christopher Friedt wrote: > That sounds a bit more accurate. Should kms and fbdev be setting both > registers then? I wonder if fbdev can use PITCHLOCK as well, rather than BYTES_PER_LINE. I will only be able to run both kms and fbdev functional tests about 9 hour

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

On 06/30/2014 02:49 PM, Christopher Friedt wrote: > On Mon, Jun 30, 2014 at 8:39 AM, Thomas Hellstrom > wrote: >> xf86-video-vmware in kms mode uses the kernel driver to set these registers. >> FWIW, the modesetting part of the kernel driver uses SVGA_REG_PITCHLOCK >> instead of >> SVGA_REG_BYTES

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

On Mon, Jun 30, 2014 at 8:39 AM, Thomas Hellstrom wrote: > xf86-video-vmware in kms mode uses the kernel driver to set these registers. > FWIW, the modesetting part of the kernel driver uses SVGA_REG_PITCHLOCK > instead of > SVGA_REG_BYTES_PER_LINE to set the pitch. That's probably where the > cla

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

On 06/30/2014 02:25 PM, Christopher Friedt wrote: > On Mon, Jun 30, 2014 at 7:48 AM, Thomas Hellstrom > wrote: >> I don't think we can blame video-vmware for this. A kernel driver change >> that breaks existing user-space is by definition a kernel driver bug, >> regardless whether exisiting user-

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

On Mon, Jun 30, 2014 at 7:48 AM, Thomas Hellstrom wrote: > I don't think we can blame video-vmware for this. A kernel driver change > that breaks existing user-space is by definition a kernel driver bug, > regardless whether exisiting user-space is doing something horrendously > stupid. I wouldn'

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

On 06/30/2014 12:19 PM, Christopher Friedt wrote: > > > On Apr 1, 2014 6:00 AM, "Thomas Hellstrom" > wrote: > > > > On 03/28/2014 02:45 AM, Dave Airlie wrote: > > > On Fri, Mar 28, 2014 at 10:45 AM, Christopher Friedt > > > mailto:chrisfri...@gmail.com>> wrote: > > >>

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

On 03/28/2014 02:45 AM, Dave Airlie wrote: > On Fri, Mar 28, 2014 at 10:45 AM, Christopher Friedt > wrote: >> Previously, the vmwgfx_fb driver would allow users to call FBIOSET_VINFO, >> but it would not adjust >> the FINFO properly, resulting in distorted screen rendering. The patch >> corrects

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

On Fri, Mar 28, 2014 at 10:45 AM, Christopher Friedt wrote: > Previously, the vmwgfx_fb driver would allow users to call FBIOSET_VINFO, but > it would not adjust > the FINFO properly, resulting in distorted screen rendering. The patch > corrects that behaviour. > > See https://bugs.gentoo.org/sh

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

This is the 2nd time I've posted the patch. Please have a look Dave. Gregkh suggested I resend this a while back after not hearing any feedback. It's a fairly simple patch. Don't forget to look at https://bugs.gentoo.org/show_bug.cgi?id=494794 because that kind of describes it all. -- To unsubsc

[PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

Previously, the vmwgfx_fb driver would allow users to call FBIOSET_VINFO, but it would not adjust the FINFO properly, resulting in distorted screen rendering. The patch corrects that behaviour. See https://bugs.gentoo.org/show_bug.cgi?id=494794 for examples. Signed-off-by: Christopher Friedt -

[PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

Previously, the vmwgfx_fb driver would allow users to call FBIOSET_VINFO, but it would not adjust the FINFO properly, resulting in distorted screen rendering. The patch corrects that behaviour. See https://bugs.gentoo.org/show_bug.cgi?id=494794 for examples. Signed-off-by: Christopher Friedt -