Re: [PATCH 1/1] epoll: call final ep_events_available() check under the lock

2020-05-05 Thread Roman Penyaev
On 2020-05-05 22:03, Andrew Morton wrote: On Tue, 05 May 2020 10:42:05 +0200 Roman Penyaev wrote: May I ask you to remove "epoll: ensure ep_poll() doesn't miss wakeup events" from your -mm queue? Jason lately found out that the patch does not fully solve the problem and this one patch is a se

Re: [PATCH 1/1] epoll: call final ep_events_available() check under the lock

2020-05-05 Thread Khazhismel Kumykov
On Tue, May 5, 2020 at 1:04 PM Andrew Morton wrote: > > On Tue, 05 May 2020 10:42:05 +0200 Roman Penyaev wrote: > > > May I ask you to remove "epoll: ensure ep_poll() doesn't miss wakeup > > events" from your -mm queue? Jason lately found out that the patch > > does not fully solve the problem an

Re: [PATCH 1/1] epoll: call final ep_events_available() check under the lock

2020-05-05 Thread Andrew Morton
On Tue, 05 May 2020 10:42:05 +0200 Roman Penyaev wrote: > May I ask you to remove "epoll: ensure ep_poll() doesn't miss wakeup > events" from your -mm queue? Jason lately found out that the patch > does not fully solve the problem and this one patch is a second > attempt to do things correctly in

Re: [PATCH 1/1] epoll: call final ep_events_available() check under the lock

2020-05-05 Thread Jason Baron
On 5/5/20 4:40 AM, Roman Penyaev wrote: > The original problem was described here: >https://lkml.org/lkml/2020/4/27/1121 > > There is a possible race when ep_scan_ready_list() leaves ->rdllist > and ->obflist empty for a short period of time although some events > are pending. It is quite l

Re: [PATCH 1/1] epoll: call final ep_events_available() check under the lock

2020-05-05 Thread Roman Penyaev
Hi Andrew, May I ask you to remove "epoll: ensure ep_poll() doesn't miss wakeup events" from your -mm queue? Jason lately found out that the patch does not fully solve the problem and this one patch is a second attempt to do things correctly in a different way (namely to do the final check unde

[PATCH 1/1] epoll: call final ep_events_available() check under the lock

2020-05-05 Thread Roman Penyaev
The original problem was described here: https://lkml.org/lkml/2020/4/27/1121 There is a possible race when ep_scan_ready_list() leaves ->rdllist and ->obflist empty for a short period of time although some events are pending. It is quite likely that ep_events_available() observes empty lists a