Re: [PATCH 1/1] fs/omfs/inode.c: replace count*size kzalloc by kcalloc

2014-06-25 Thread Bob Copeland
On Wed, Jun 25, 2014 at 10:03:26PM +0200, Fabian Frederick wrote: > > >     bitmap_size = DIV_ROUND_UP(sbi->s_num_blocks, 8); > > > > > Agreed - even though the FS data structures support 64-bit block > > count, I've never seen an OMFS fs with more than about 2M blocks > > (typical device had 20 gi

Re: [PATCH 1/1] fs/omfs/inode.c: replace count*size kzalloc by kcalloc

2014-06-25 Thread Fabian Frederick
> Le 25 juin 2014 à 21:02, Bob Copeland a écrit : > > > On Wed, Jun 25, 2014 at 11:27:21AM -0700, Linus Torvalds wrote: > > On Wed, Jun 25, 2014 at 11:17 AM, Fabian Frederick wrote: > > > kcalloc manages count*sizeof overflow. > > > > As far as I can tell, any overflow has happened long before,

Re: [PATCH 1/1] fs/omfs/inode.c: replace count*size kzalloc by kcalloc

2014-06-25 Thread Bob Copeland
On Wed, Jun 25, 2014 at 08:17:17PM +0200, Fabian Frederick wrote: > kcalloc manages count*sizeof overflow. > > Cc: Bob Copeland > Cc: Andrew Morton > Signed-off-by: Fabian Frederick Acked-by: Bob Copeland -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line

Re: [PATCH 1/1] fs/omfs/inode.c: replace count*size kzalloc by kcalloc

2014-06-25 Thread Bob Copeland
On Wed, Jun 25, 2014 at 11:27:21AM -0700, Linus Torvalds wrote: > On Wed, Jun 25, 2014 at 11:17 AM, Fabian Frederick wrote: > > kcalloc manages count*sizeof overflow. > > As far as I can tell, any overflow has happened long before, in > > bitmap_size = DIV_ROUND_UP(sbi->s_num_blocks, 8); >

Re: [PATCH 1/1] fs/omfs/inode.c: replace count*size kzalloc by kcalloc

2014-06-25 Thread Linus Torvalds
On Wed, Jun 25, 2014 at 11:17 AM, Fabian Frederick wrote: > kcalloc manages count*sizeof overflow. As far as I can tell, any overflow has happened long before, in bitmap_size = DIV_ROUND_UP(sbi->s_num_blocks, 8); where 'sbi->s_num_blocks' i san u64, and 'bitmap_size' is an 'int'. I don't t

[PATCH 1/1] fs/omfs/inode.c: replace count*size kzalloc by kcalloc

2014-06-25 Thread Fabian Frederick
kcalloc manages count*sizeof overflow. Cc: Bob Copeland Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/omfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c index ec58c76..ba88197 100644 --- a/fs/omfs/inode.c +++ b/fs/omfs/