Re: [Cluster-devel] [PATCH 1/1] gfs2: incorrect check for debugfs returns

2015-03-30 Thread Bob Peterson
- Original Message - > debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs > is not configured, so the return value should be checked against ERROR_VALUE > as well, otherwise the later dereference of the dentry pointer would crash > the kernel. > > Signed-off-by:

Re: [Cluster-devel] [PATCH 1/1] gfs2: incorrect check for debugfs returns

2015-03-30 Thread Bob Peterson
- Original Message - debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs is not configured, so the return value should be checked against ERROR_VALUE as well, otherwise the later dereference of the dentry pointer would crash the kernel. Signed-off-by: Chengyu

Re: [PATCH 1/1] gfs2: incorrect check for debugfs returns

2015-03-24 Thread Steven Whitehouse
Hi, On 24/03/15 02:36, Chengyu Song wrote: debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs is not configured, so the return value should be checked against ERROR_VALUE as well, otherwise the later dereference of the dentry pointer would crash the kernel. Looks

Re: [PATCH 1/1] gfs2: incorrect check for debugfs returns

2015-03-24 Thread Steven Whitehouse
Hi, On 24/03/15 02:36, Chengyu Song wrote: debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs is not configured, so the return value should be checked against ERROR_VALUE as well, otherwise the later dereference of the dentry pointer would crash the kernel. Looks

[PATCH 1/1] gfs2: incorrect check for debugfs returns

2015-03-23 Thread Chengyu Song
debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs is not configured, so the return value should be checked against ERROR_VALUE as well, otherwise the later dereference of the dentry pointer would crash the kernel. Signed-off-by: Chengyu Song --- fs/gfs2/glock.c | 47

[PATCH 1/1] gfs2: incorrect check for debugfs returns

2015-03-23 Thread Chengyu Song
debugfs_create_dir and debugfs_create_file may return -ENODEV when debugfs is not configured, so the return value should be checked against ERROR_VALUE as well, otherwise the later dereference of the dentry pointer would crash the kernel. Signed-off-by: Chengyu Song cson...@gatech.edu ---