On Tue, 2015-06-30 at 22:25 +, Fujinaka, Todd wrote:
> I've submitted a version to intel-wired-lan that addresses the original
> issue as well as Joe Perches's suggestion to just delete the define.
Please cc netdev next time too.
--
To unsubscribe from this list: send the line "unsubscribe l
I've submitted a version to intel-wired-lan that addresses the original issue
as well as Joe Perches's suggestion to just delete the define.
Todd Fujinaka
Software Application Engineer
Networking Division (ND)
Intel Corporation
todd.fujin...@intel.com
(503) 712-4565
--
To unsubscribe from this li
On Tue, 2015-06-30 at 20:16 +, Fujinaka, Todd wrote:
> Sorry for the top-posting, but I'm provided with the tools they give me
> and bottom posting from Outlook just confuses email threads. Plus, this
> was crossposted all over creation and cc-ed to anyone with an intel
> address.
Not quite.
On Tue, Jun 30, 2015 at 1:16 PM, Fujinaka, Todd wrote:
> I still would say no if I'm allowed, because to guarantee that this change -
> that I don't think fixes anything - works in all cases, we need to do an
> incredible amount of regression testing. Every variant of every Intel part
> that u
Hi!
Am 30.06.2015 um 22:16 schrieb Fujinaka, Todd:
> Sorry for the top-posting, but I'm provided with the tools they give me and
> bottom posting from Outlook just confuses email threads. Plus, this was
> crossposted all over creation and cc-ed to anyone with an intel address.
>
> I still would
yborny, Carolyn; Skidmore, Donald C; Vick, Matthew; Ronciak, John; Williams,
Mitch A; intel-wired-...@lists.osuosl.org; net...@vger.kernel.org;
linux-kernel@vger.kernel.org; panka...@samsung.com
Subject: Re: [Intel-wired-lan] [PATCH 1/1] igb: Use ARRAY_SIZE instead fo
sizeof(a)/sizeof(a[0])
On Tue
On Tue, Jun 30, 2015 at 4:53 PM, Fujinaka, Todd wrote:
> I don't see the reason this is needed so I'm going to say NAK.
Using generic functions is always better than open coded stuff.
Linux's ARRAY_SIZE also makes sure that the passed variable is actually
an array.
--
Thanks,
//richard
--
To un
nel.org
Cc: Maninder Singh; panka...@samsung.com
Subject: [Intel-wired-lan] [PATCH 1/1] igb: Use ARRAY_SIZE instead fo
sizeof(a)/sizeof(a[0])
Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0])
Signed-off-by: Maninder Singh
Reviewed-by: Yogesh Narayan Gaur
---
drivers/net/ethernet/intel/igb/e1000_ph
Hi Joe,
>> Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0])
>
>I think all of these #defines should be removed instead
>as they are all used only once.
If we replcase only ARRAY_SIZE then cood will look alike
to drivers/net/ethernet/intel/e1000e/phy.c
And if we have to remove these #defines , th
On Tue, 2015-06-30 at 10:25 +0530, Maninder Singh wrote:
> Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0])
I think all of these #defines should be removed instead
as they are all used only once.
> diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c
> b/drivers/net/ethernet/intel/igb/e1000_p
Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0])
Signed-off-by: Maninder Singh
Reviewed-by: Yogesh Narayan Gaur
---
drivers/net/ethernet/intel/igb/e1000_phy.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c
b/drivers/net/e
11 matches
Mail list logo
