Re: [PATCH 1/1] infiniband: Remove redundant NULL check before kfree

2015-07-09 Thread Christoph Lameter
This is correct as is. Acked-by: Christoph Lameter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/1] infiniband: Remove redundant NULL check before kfree

2015-07-08 Thread Doug Ledford
On 07/08/2015 12:23 AM, Maninder Singh wrote: > Hello, > >>> + for (i = 0; i < dev->caps.num_ports; i++) >>> + kfree(dm[i]); >>> goto out; >>> } >>> } >>> -- >>> 1.7.9.5 >>> >> >> If you are going to change this, you m

Re: [PATCH 1/1] infiniband: Remove redundant NULL check before kfree

2015-07-07 Thread Maninder Singh
Hello, >> +for (i = 0; i < dev->caps.num_ports; i++) >> +kfree(dm[i]); >> goto out; >> } >> } >> -- >> 1.7.9.5 >> > >If you are going to change this, you might as well make it 100% correct: > >i—-; >while (i >=

Re: [PATCH 1/1] infiniband: Remove redundant NULL check before kfree

2015-07-07 Thread Doug Ledford
> On Jun 26, 2015, at 3:09 AM, Maninder Singh wrote: > > kfree(NULL) is safe and this check is probably not required > > Signed-off-by: Maninder Singh > Reviewed-by: Akhilesh Kumar > --- > drivers/infiniband/hw/mlx4/main.c |6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > d

[PATCH 1/1] infiniband: Remove redundant NULL check before kfree

2015-06-26 Thread Maninder Singh
kfree(NULL) is safe and this check is probably not required Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- drivers/infiniband/hw/mlx4/main.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx