Re: [PATCH 1/1] ipv4: off-by-one in continuation handling in /proc/net/route

2015-08-13 Thread Alexander Duyck
On 08/13/2015 08:10 AM, Eric Dumazet wrote: On Thu, 2015-08-13 at 11:21 +0100, Andy Whitcroft wrote: When generating /proc/net/route we emit a header followed by a line for each route. When a short read is performed we will restart this process based on the open file descriptor. When

Re: [PATCH 1/1] ipv4: off-by-one in continuation handling in /proc/net/route

2015-08-13 Thread Eric Dumazet
On Thu, 2015-08-13 at 11:21 +0100, Andy Whitcroft wrote: > When generating /proc/net/route we emit a header followed by a line for > each route. When a short read is performed we will restart this process > based on the open file descriptor. When calculating the start point we > fail to take

[PATCH 1/1] ipv4: off-by-one in continuation handling in /proc/net/route

2015-08-13 Thread Andy Whitcroft
When generating /proc/net/route we emit a header followed by a line for each route. When a short read is performed we will restart this process based on the open file descriptor. When calculating the start point we fail to take into account that the 0th entry is the header. This leads us to

[PATCH 1/1] ipv4: off-by-one in continuation handling in /proc/net/route

2015-08-13 Thread Andy Whitcroft
When generating /proc/net/route we emit a header followed by a line for each route. When a short read is performed we will restart this process based on the open file descriptor. When calculating the start point we fail to take into account that the 0th entry is the header. This leads us to

Re: [PATCH 1/1] ipv4: off-by-one in continuation handling in /proc/net/route

2015-08-13 Thread Eric Dumazet
On Thu, 2015-08-13 at 11:21 +0100, Andy Whitcroft wrote: When generating /proc/net/route we emit a header followed by a line for each route. When a short read is performed we will restart this process based on the open file descriptor. When calculating the start point we fail to take into

Re: [PATCH 1/1] ipv4: off-by-one in continuation handling in /proc/net/route

2015-08-13 Thread Alexander Duyck
On 08/13/2015 08:10 AM, Eric Dumazet wrote: On Thu, 2015-08-13 at 11:21 +0100, Andy Whitcroft wrote: When generating /proc/net/route we emit a header followed by a line for each route. When a short read is performed we will restart this process based on the open file descriptor. When