Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock

2016-10-12 Thread Theodore Ts'o
On Wed, Oct 12, 2016 at 04:58:35PM -0600, Andreas Dilger wrote: > On Mar 17, 2015, at 8:08 PM, Taesoo Kim wrote: > > > > When 'jh->b_transaction == transaction' (asserted by below) > > > > J_ASSERT_JH(jh, (jh->b_transaction == transaction || ... > > > > 'journal->j_list_lock' will be in

Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock

2016-10-12 Thread Andreas Dilger
On Mar 17, 2015, at 8:08 PM, Taesoo Kim wrote: > > When 'jh->b_transaction == transaction' (asserted by below) > > J_ASSERT_JH(jh, (jh->b_transaction == transaction || ... > > 'journal->j_list_lock' will be incorrectly unlocked, since > spin_lock() is called only in the 'if' and 'else-i

Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock

2015-03-19 Thread Lukáš Czerner
ch.edu, > cson...@gatech.edu > Subject: Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock > > On 03/19/15 at 10:48am, Lukáš Czerner wrote: > > On Wed, 18 Mar 2015, Taesoo Kim wrote: > > > > > Date: Wed, 18 Mar 2015 13:39:31 -0400 > > > From: Ta

Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock

2015-03-19 Thread Taesoo Kim
ernel@vger.kernel.org, > > chang...@gatech.edu, sanid...@gatech.edu, b...@gatech.edu, > > cson...@gatech.edu > > Subject: Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock > > > > > The patch looks good, thanks. > > > > Thank you. > &g

Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock

2015-03-19 Thread Lukáš Czerner
ch.edu, > cson...@gatech.edu > Subject: Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock > > > The patch looks good, thanks. > > Thank you. > > > Reviewed-by: Lukas Czerner > > > > Btw, were you able to reproduce the problem, or have you seen

Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock

2015-03-18 Thread Taesoo Kim
> The patch looks good, thanks. Thank you. > Reviewed-by: Lukas Czerner > > Btw, were you able to reproduce the problem, or have you seen the > problem in the wild ? Or did you just spot it in the code ? We are developing a static checker to spot inconsistent programming patterns; our first g

Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock

2015-03-18 Thread Lukáš Czerner
edu, Taesoo Kim > Subject: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock > > When 'jh->b_transaction == transaction' (asserted by below) > > J_ASSERT_JH(jh, (jh->b_transaction == transaction || ... > > 'journal->j_list_lock' will be

[PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock

2015-03-17 Thread Taesoo Kim
When 'jh->b_transaction == transaction' (asserted by below) J_ASSERT_JH(jh, (jh->b_transaction == transaction || ... 'journal->j_list_lock' will be incorrectly unlocked, since the the lock is aquired only at the end of if / else-if statements (missing the else case). Signed-off-by: Taesoo Kim