Re: [PATCH 1/1] kernel/debug/debug_core.c: Logging clean-up

2014-06-12 Thread Joe Perches
On Thu, 2014-06-12 at 20:48 +0200, Fabian Frederick wrote: > -Convert printk( to pr_foo() > -Add pr_fmt > -Coalesce formats Might as well add missing newlines and maybe remove unnecessary periods. > diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c [] > @@ -196,8 +199,8 @@ int __

Re: [PATCH 1/1] kernel/debug/debug_core.c: Logging clean-up

2014-06-12 Thread Jason Wessel
On 06/12/2014 01:48 PM, Fabian Frederick wrote: > -Convert printk( to pr_foo() > -Add pr_fmt > -Coalesce formats > > Cc: Jason Wessel > Cc: Andrew Morton > Signed-off-by: Fabian Frederick Thanks. I looked through all the bits to make sure there were no cases were we relied on a printk out to

[PATCH 1/1] kernel/debug/debug_core.c: Logging clean-up

2014-06-12 Thread Fabian Frederick
-Convert printk( to pr_foo() -Add pr_fmt -Coalesce formats Cc: Jason Wessel Cc: Andrew Morton Signed-off-by: Fabian Frederick --- kernel/debug/debug_core.c | 43 +-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/kernel/debug/debug_core.