On Mon, Apr 14, 2014 at 12:27:47PM -0400, Pranith Kumar wrote:
> On Mon, Apr 14, 2014 at 12:19 PM, Pranith Kumar wrote:
> > Hi Paul,
> >
> > On Mon, Apr 14, 2014 at 12:07 PM, Paul E. McKenney
> > wrote:
> >> On Sun, Apr 13, 2014 at 05:53:53PM -0400, Pranith Kumar wrote:
> >>> remove duplicate def
On Mon, Apr 14, 2014 at 09:53:27AM -0700, Joe Perches wrote:
> On Mon, 2014-04-14 at 09:32 -0700, Paul E. McKenney wrote:
> > On Mon, Apr 14, 2014 at 12:19:31PM -0400, Pranith Kumar wrote:
> > > Hi Paul,
> > >
> > > On Mon, Apr 14, 2014 at 12:07 PM, Paul E. McKenney
> > > wrote:
> > > > On Sun, A
On Mon, 2014-04-14 at 09:32 -0700, Paul E. McKenney wrote:
> On Mon, Apr 14, 2014 at 12:19:31PM -0400, Pranith Kumar wrote:
> > Hi Paul,
> >
> > On Mon, Apr 14, 2014 at 12:07 PM, Paul E. McKenney
> > wrote:
> > > On Sun, Apr 13, 2014 at 05:53:53PM -0400, Pranith Kumar wrote:
> > >> remove duplica
On Mon, Apr 14, 2014 at 12:19:31PM -0400, Pranith Kumar wrote:
> Hi Paul,
>
> On Mon, Apr 14, 2014 at 12:07 PM, Paul E. McKenney
> wrote:
> > On Sun, Apr 13, 2014 at 05:53:53PM -0400, Pranith Kumar wrote:
> >> remove duplicate definition of extern resched_cpu
> >>
> >> Signed-off-by: Pranith Kuma
On Mon, Apr 14, 2014 at 12:19 PM, Pranith Kumar wrote:
> Hi Paul,
>
> On Mon, Apr 14, 2014 at 12:07 PM, Paul E. McKenney
> wrote:
>> On Sun, Apr 13, 2014 at 05:53:53PM -0400, Pranith Kumar wrote:
>>> remove duplicate definition of extern resched_cpu
>>>
>>> Signed-off-by: Pranith Kumar
>>
>> Hel
Hi Paul,
On Mon, Apr 14, 2014 at 12:07 PM, Paul E. McKenney
wrote:
> On Sun, Apr 13, 2014 at 05:53:53PM -0400, Pranith Kumar wrote:
>> remove duplicate definition of extern resched_cpu
>>
>> Signed-off-by: Pranith Kumar
>
> Hello, Pranith,
>
> When I apply this patch I get the following:
>
> /ho
On Sun, Apr 13, 2014 at 11:18 PM, Joe Perches wrote:
>> As the comment mentions, resched_cpu is internal to the scheduler and
>> hence is in sched/sched.h file and not in linux/sched.h.
>
> Note the use of quotes and lack of angle brackets.
>
>> sched/sched.h cannot be included in other subsystem
On Sun, 2014-04-13 at 23:03 -0400, Pranith Kumar wrote:
> On Sun, Apr 13, 2014 at 10:50 PM, Joe Perches wrote:
> >> -/*
> >> - * This function really isn't for public consumption, but RCU is special
> >> in
> >> - * that context switches can allow the state machine to make progress.
> >> - */
> >
On Sun, Apr 13, 2014 at 10:50 PM, Joe Perches wrote:
>>
>> -/*
>> - * This function really isn't for public consumption, but RCU is special in
>> - * that context switches can allow the state machine to make progress.
>> - */
>> -extern void resched_cpu(int cpu);
>
> why not #include "sched.h"
>
>
On Sun, 2014-04-13 at 21:39 -0400, Pranith Kumar wrote:
[]
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
[]
> @@ -947,12 +947,6 @@ static void print_other_cpu_stall(struct rcu_state *rsp)
> force_quiescent_state(rsp); /* Kick them all. */
> }
>
> -/*
> - * This function really isn't
Signed-off-by: Pranith Kumar
---
kernel/rcu/tree.c |6 --
1 file changed, 6 deletions(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 0c47e30..67e850a 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -947,12 +947,6 @@ static void print_other_cpu_stall(struct rcu_stat
11 matches
Mail list logo
