Re: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions

2013-03-14 Thread Michal Hocko
On Thu 14-03-13 15:11:09, Gerald Schaefer wrote: > On Thu, 14 Mar 2013 14:14:04 +0100 > Michal Hocko wrote: > > > On Tue 12-03-13 19:48:26, Gerald Schaefer wrote: > > > Commit abf09bed3c "s390/mm: implement software dirty bits" introduced > > > another difference in the pte layout vs. the pmd lay

Re: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions

2013-03-14 Thread Gerald Schaefer
On Thu, 14 Mar 2013 14:14:04 +0100 Michal Hocko wrote: > On Tue 12-03-13 19:48:26, Gerald Schaefer wrote: > > Commit abf09bed3c "s390/mm: implement software dirty bits" introduced > > another difference in the pte layout vs. the pmd layout on s390, > > thoroughly breaking the s390 support for hug

Re: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions

2013-03-14 Thread Hillf Danton
On Thu, Mar 14, 2013 at 9:14 PM, Michal Hocko wrote: > Ouch, this adds a lot of code that is almost same for all archs except > for some. Can we just make one common definition and define only those > that differ, please? > Wonder if he is the guy that added THP for s390, which was a model work in

Re: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions

2013-03-14 Thread Michal Hocko
On Tue 12-03-13 19:48:26, Gerald Schaefer wrote: > Commit abf09bed3c "s390/mm: implement software dirty bits" introduced > another difference in the pte layout vs. the pmd layout on s390, > thoroughly breaking the s390 support for hugetlbfs. This requires > replacing some more pte_xxx functions in

Re: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions

2013-03-12 Thread Gerald Schaefer
On Tue, 12 Mar 2013 15:00:37 -0400 Chris Metcalf wrote: > On 3/12/2013 2:48 PM, Gerald Schaefer wrote: > > Commit abf09bed3c "s390/mm: implement software dirty bits" introduced > > another difference in the pte layout vs. the pmd layout on s390, > > thoroughly breaking the s390 support for hugetl

Re: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions

2013-03-12 Thread Chris Metcalf
On 3/12/2013 2:48 PM, Gerald Schaefer wrote: > Commit abf09bed3c "s390/mm: implement software dirty bits" introduced > another difference in the pte layout vs. the pmd layout on s390, > thoroughly breaking the s390 support for hugetlbfs. This requires > replacing some more pte_xxx functions in mm/h

[PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions

2013-03-12 Thread Gerald Schaefer
Commit abf09bed3c "s390/mm: implement software dirty bits" introduced another difference in the pte layout vs. the pmd layout on s390, thoroughly breaking the s390 support for hugetlbfs. This requires replacing some more pte_xxx functions in mm/hugetlbfs.c with a huge_pte_xxx version. This patch i