Re: (2) [PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list

2020-04-29 Thread Michal Hocko
On Wed 29-04-20 18:59:40, Vaneet Narang wrote: > Hi Michal,  > > >> > > >> >Acked-by: Michal Hocko  > >> > > >> >Is there any reason to move declarations here? > >> > > >>  > >> "unsigned int ret" was changed mistakenely, sending V2. > >> and "unsigned int nr_reclaimed" is changed to remove hole.

RE:(2) [PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list

2020-04-29 Thread Vaneet Narang
Hi Michal,  >> > >> >Acked-by: Michal Hocko  >> > >> >Is there any reason to move declarations here? >> > >>  >> "unsigned int ret" was changed mistakenely, sending V2. >> and "unsigned int nr_reclaimed" is changed to remove hole.   >Could you be more specific? Have you seen a better stack 

Re: [PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list

2020-04-29 Thread Michal Hocko
On Wed 29-04-20 18:23:23, Maninder Singh wrote: > > Hi, > > > > >Acked-by: Michal Hocko > > > >Is there any reason to move declarations here? > > > > "unsigned int ret" was changed mistakenely, sending V2. > and "unsigned int nr_reclaimed" is changed to remove hole. Could you be more

RE:[PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list

2020-04-29 Thread Maninder Singh
Hi, > >Acked-by: Michal Hocko > >Is there any reason to move declarations here? > "unsigned int ret" was changed mistakenely, sending V2. and "unsigned int nr_reclaimed" is changed to remove hole. >> -unsigned long reclaim_clean_pages_from_list(struct zone *zone, >> +unsigned int

Re: [PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list

2020-04-29 Thread Michal Hocko
On Wed 29-04-20 11:29:27, Maninder Singh wrote: > 'commit 3c710c1ad11b ("mm, vmscan: > extract shrink_page_list reclaim counters into a struct")' > > changed data type for the function, > so changing return type for funciton and its caller. > > Signed-off-by: Vaneet Narang > Signed-off-by:

[PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list

2020-04-29 Thread Maninder Singh
'commit 3c710c1ad11b ("mm, vmscan: extract shrink_page_list reclaim counters into a struct")' changed data type for the function, so changing return type for funciton and its caller. Signed-off-by: Vaneet Narang Signed-off-by: Maninder Singh --- mm/internal.h | 2 +- mm/page_alloc.c | 2