Re: [PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...))

2014-03-04 Thread Stephen Rothwell
Hi Andrew, On Tue, 4 Mar 2014 13:26:04 -0800 Andrew Morton wrote: > > On Sun, 2 Mar 2014 19:09:58 +0530 Gideon Israel Dsouza > wrote: > > > To increase compiler portability there is which > > provides convenience macros for various gcc constructs. Eg: __weak > > for __attribute__((weak)).

Re: [PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...))

2014-03-04 Thread Andrew Morton
On Sun, 2 Mar 2014 19:09:58 +0530 Gideon Israel Dsouza wrote: > To increase compiler portability there is which > provides convenience macros for various gcc constructs. Eg: __weak > for __attribute__((weak)). I've replaced all instances of gcc > attributes with the right macro in the

Re: [PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...))

2014-03-04 Thread Andrew Morton
On Sun, 2 Mar 2014 19:09:58 +0530 Gideon Israel Dsouza gidisr...@gmail.com wrote: To increase compiler portability there is linux/compiler.h which provides convenience macros for various gcc constructs. Eg: __weak for __attribute__((weak)). I've replaced all instances of gcc attributes

Re: [PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...))

2014-03-04 Thread Stephen Rothwell
Hi Andrew, On Tue, 4 Mar 2014 13:26:04 -0800 Andrew Morton a...@linux-foundation.org wrote: On Sun, 2 Mar 2014 19:09:58 +0530 Gideon Israel Dsouza gidisr...@gmail.com wrote: To increase compiler portability there is linux/compiler.h which provides convenience macros for various gcc

[PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...))

2014-03-02 Thread Gideon Israel Dsouza
To increase compiler portability there is which provides convenience macros for various gcc constructs. Eg: __weak for __attribute__((weak)). I've replaced all instances of gcc attributes with the right macro in the memory management (/mm) subsystem. Signed-off-by: Gideon Israel Dsouza ---

[PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...))

2014-03-02 Thread Gideon Israel Dsouza
To increase compiler portability there is linux/compiler.h which provides convenience macros for various gcc constructs. Eg: __weak for __attribute__((weak)). I've replaced all instances of gcc attributes with the right macro in the memory management (/mm) subsystem. Signed-off-by: Gideon

Re: [PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...))

2014-03-01 Thread Geert Uytterhoeven
On Sat, Mar 1, 2014 at 5:02 PM, Gideon Israel Dsouza wrote: > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -9,6 +9,8 @@ > #include > #include > #include > +#include Please try to insert new includes in alphabetical order, to avoid merge conflicts. It's no always easy, as lots of include

[PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...))

2014-03-01 Thread Gideon Israel Dsouza
To increase compiler portability there is which provides convenience macros for various gcc constructs. Eg: __weak for __attribute__((weak)). I've replaced all instances of gcc attributes with the right macro in the memory management (/mm) subsystem. Signed-off-by: Gideon Israel Dsouza ---

[PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...))

2014-03-01 Thread Gideon Israel Dsouza
To increase compiler portability there is linux/compiler.h which provides convenience macros for various gcc constructs. Eg: __weak for __attribute__((weak)). I've replaced all instances of gcc attributes with the right macro in the memory management (/mm) subsystem. Signed-off-by: Gideon

Re: [PATCH 1/1] mm: use macros from compiler.h instead of __attribute__((...))

2014-03-01 Thread Geert Uytterhoeven
On Sat, Mar 1, 2014 at 5:02 PM, Gideon Israel Dsouza gidisr...@gmail.com wrote: --- a/mm/sparse.c +++ b/mm/sparse.c @@ -9,6 +9,8 @@ #include linux/export.h #include linux/spinlock.h #include linux/vmalloc.h +#include linux/compiler.h Please try to insert new includes in alphabetical