Re: [PATCH 1/1] move exit_task_namespaces() outside of exit_notify()

2013-06-14 Thread Oleg Nesterov
On 06/13, Andrew Vagin wrote: > > On Sat, Apr 13, 2013 at 05:55:21PM +0200, Oleg Nesterov wrote: > > exit_notify() does exit_task_namespaces() after > > forget_original_parent(). This was needed to ensure that ->nsproxy > > can't be cleared prematurely, an exiting child we are going to > > reparent

Re: [PATCH 1/1] move exit_task_namespaces() outside of exit_notify()

2013-06-13 Thread Andrew Vagin
On Sat, Apr 13, 2013 at 05:55:21PM +0200, Oleg Nesterov wrote: > exit_notify() does exit_task_namespaces() after > forget_original_parent(). This was needed to ensure that ->nsproxy > can't be cleared prematurely, an exiting child we are going to > reparent can do do_notify_parent() and use the par

Re: [PATCH 1/1] move exit_task_namespaces() outside of exit_notify()

2013-04-15 Thread Oleg Nesterov
On 04/15, Andrey Wagin wrote: > > It looks good for me. I have tested it a bit and don't find any problem. > Oleg, thank you. > > Acked-by: Andrew Vagin Thanks Andrey and Eric. > > --- x/kernel/exit.c > > +++ x/kernel/exit.c > > @@ -649,7 +649,6 @@ static void exit_notify(struct task_stru > >

Re: [PATCH 1/1] move exit_task_namespaces() outside of exit_notify()

2013-04-15 Thread Andrey Wagin
2013/4/13 Oleg Nesterov > > exit_notify() does exit_task_namespaces() after > forget_original_parent(). This was needed to ensure that ->nsproxy > can't be cleared prematurely, an exiting child we are going to > reparent can do do_notify_parent() and use the parent's (ours) pid_ns. > > However, af

Re: [PATCH 1/1] move exit_task_namespaces() outside of exit_notify()

2013-04-13 Thread Eric W. Biederman
Oleg Nesterov writes: > exit_notify() does exit_task_namespaces() after > forget_original_parent(). This was needed to ensure that ->nsproxy > can't be cleared prematurely, an exiting child we are going to > reparent can do do_notify_parent() and use the parent's (ours) pid_ns. > > However, after

[PATCH 1/1] move exit_task_namespaces() outside of exit_notify()

2013-04-13 Thread Oleg Nesterov
exit_notify() does exit_task_namespaces() after forget_original_parent(). This was needed to ensure that ->nsproxy can't be cleared prematurely, an exiting child we are going to reparent can do do_notify_parent() and use the parent's (ours) pid_ns. However, after 32084504 "pidns: use task_active_p