Re: [PATCH 1/1] net/dsa/dsa.c: remove null test before kfree

2014-06-21 Thread David Miller
From: Joe Perches Date: Sat, 21 Jun 2014 07:10:06 -0700 > In this case, it seems the simple substitution of > "unnecessary null" to the subject would have been > enough validation. Agreed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majo

Re: [PATCH 1/1] net/dsa/dsa.c: remove null test before kfree

2014-06-21 Thread Joe Perches
On Sat, 2014-06-21 at 11:36 +0200, Fabian Frederick wrote: > On Sat, 21 Jun 2014 10:37:24 +0200 Bjørn Mork wrote: > > On 20 June 2014 22:36:47 CEST, Fabian Frederick wrote: > > > Fix checkpatch warning: > > > WARNING: kfree(NULL) is safe this check is probably not required > > > > "probably not"

Re: [PATCH 1/1] net/dsa/dsa.c: remove null test before kfree

2014-06-21 Thread Fabian Frederick
On Sat, 21 Jun 2014 10:37:24 +0200 Bjørn Mork wrote: > > > On 20 June 2014 22:36:47 CEST, Fabian Frederick wrote: > >Fix checkpatch warning: > >WARNING: kfree(NULL) is safe this check is probably not required > > "probably not" implies that there are cases where the check *is* required. > T

Re: [PATCH 1/1] net/dsa/dsa.c: remove null test before kfree

2014-06-21 Thread Bjørn Mork
On 20 June 2014 22:36:47 CEST, Fabian Frederick wrote: >Fix checkpatch warning: >WARNING: kfree(NULL) is safe this check is probably not required "probably not" implies that there are cases where the check *is* required. That means that your commit message should explain why this particular c

[PATCH 1/1] net/dsa/dsa.c: remove null test before kfree

2014-06-20 Thread Fabian Frederick
Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required Cc: "David S. Miller" Cc: Grant Likely Cc: net...@vger.kernel.org Signed-off-by: Fabian Frederick --- net/dsa/dsa.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/dsa/dsa.c b/net