Re: [PATCH 1/1] net: bridge: set error code on failure

2016-12-05 Thread David Miller
From: Pan Bian Date: Sat, 3 Dec 2016 19:33:23 +0800 > Function br_sysfs_addbr() does not set error code when the call > kobject_create_and_add() returns a NULL pointer. It may be better to > return "-ENOMEM" when kobject_create_and_add() fails. > > Bugzilla: https://bugzilla.kernel.org/show_bug

Re: [PATCH 1/1] net: bridge: set error code on failure

2016-12-05 Thread Stephen Hemminger
On Sat, 3 Dec 2016 19:33:23 +0800 Pan Bian wrote: > Function br_sysfs_addbr() does not set error code when the call > kobject_create_and_add() returns a NULL pointer. It may be better to > return "-ENOMEM" when kobject_create_and_add() fails. > > Bugzilla: https://bugzilla.kernel.org/show_bug.c

[PATCH 1/1] net: bridge: set error code on failure

2016-12-03 Thread Pan Bian
Function br_sysfs_addbr() does not set error code when the call kobject_create_and_add() returns a NULL pointer. It may be better to return "-ENOMEM" when kobject_create_and_add() fails. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188781 Signed-off-by: Pan Bian --- net/bridge/br_sysfs