Re: [PATCH 1/1] net: ipv4: refine the logic for determining daddr in ip_queue_xmit.

2013-01-15 Thread Cong Ding
On Mon, Jan 14, 2013 at 08:57:09PM -0800, Eric Dumazet wrote: > On Tue, 2013-01-15 at 12:47 +0800, Harvey Yang wrote: > > The destination address daddr is faddr if source route option is set, > > otherwise it is inet_daddr. So use if-else to assign the value. > > > > Signed-off-by: Harvey Yang >

Re: [PATCH 1/1] net: ipv4: refine the logic for determining daddr in ip_queue_xmit.

2013-01-14 Thread Eric Dumazet
On Tue, 2013-01-15 at 12:47 +0800, Harvey Yang wrote: > The destination address daddr is faddr if source route option is set, > otherwise it is inet_daddr. So use if-else to assign the value. > > Signed-off-by: Harvey Yang > --- > net/ipv4/ip_output.c |4 ++-- > 1 files changed, 2 insertion

Re: [PATCH 1/1] net: ipv4: refine the logic for determining daddr in ip_queue_xmit.

2013-01-14 Thread David Miller
From: Harvey Yang Date: Tue, 15 Jan 2013 12:47:35 +0800 > The destination address daddr is faddr if source route option is set, > otherwise it is inet_daddr. So use if-else to assign the value. > > Signed-off-by: Harvey Yang You are changing nothing in how this code behaves. And stylisticall

[PATCH 1/1] net: ipv4: refine the logic for determining daddr in ip_queue_xmit.

2013-01-14 Thread Harvey Yang
The destination address daddr is faddr if source route option is set, otherwise it is inet_daddr. So use if-else to assign the value. Signed-off-by: Harvey Yang --- net/ipv4/ip_output.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_output.c b/net/ipv4/i