Re: [PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule

2016-06-02 Thread Vineet Gupta
On Monday 30 May 2016 11:05 AM, David Miller wrote: > From: Elad Kanfi > Date: Thu, 26 May 2016 15:00:06 +0300 > >> From: Elad Kanfi >> >> Since NAPI works by shutting down event interrupts when theres >> work and turning them on when theres none, the net driver must >> make sure that interrupts

Re: [PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule

2016-05-29 Thread David Miller
From: Elad Kanfi Date: Thu, 26 May 2016 15:00:06 +0300 > From: Elad Kanfi > > Since NAPI works by shutting down event interrupts when theres > work and turning them on when theres none, the net driver must > make sure that interrupts are disabled when it reschedules polling. > By calling napi_r

Re: [PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule

2016-05-26 Thread Vineet Gupta
Hi Elad, Noam, On Thursday 26 May 2016 11:23 PM, Alexey Brodkin wrote: > > We just bumped into the same problem (data exchange hangs on the very first > "ping") > with released Linux v4.6 and linux-next on our nSIM OSCI virtual platform. > > I believe it was commit 05c00d82f4d1 ("net: nps_enet

Re: [PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule

2016-05-26 Thread Alexey Brodkin
Hi Elad, On Thu, 2016-05-26 at 15:00 +0300, Elad Kanfi wrote: > From: Elad Kanfi > > Since NAPI works by shutting down event interrupts when theres > work and turning them on when theres none, the net driver must > make sure that interrupts are disabled when it reschedules polling. > By calling

[PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule

2016-05-26 Thread Elad Kanfi
From: Elad Kanfi Since NAPI works by shutting down event interrupts when theres work and turning them on when theres none, the net driver must make sure that interrupts are disabled when it reschedules polling. By calling napi_reschedule, the driver switches to polling mode, therefor there should