Re: [PATCH 1/1] net: pegasus: simplify logical constraint

2016-05-23 Thread David Miller
From: Heinrich Schuchardt Date: Wed, 18 May 2016 20:40:51 +0200 > If !count is true, count < 4 is also true. > > Signed-off-by: Heinrich Schuchardt Applied.

Re: [PATCH 1/1] net: pegasus: simplify logical constraint

2016-05-23 Thread David Miller
From: Heinrich Schuchardt Date: Wed, 18 May 2016 20:40:51 +0200 > If !count is true, count < 4 is also true. > > Signed-off-by: Heinrich Schuchardt Applied.

Re: [PATCH 1/1] net: pegasus: simplify logical constraint

2016-05-18 Thread Petko Manolov
On 16-05-18 20:40:51, Heinrich Schuchardt wrote: > If !count is true, count < 4 is also true. Yep, you're right. However, gcc optimizes away the first condition. What you really got me to think about is whether 4 is the right number. I guess i shall refer to the HW documentation.

Re: [PATCH 1/1] net: pegasus: simplify logical constraint

2016-05-18 Thread Petko Manolov
On 16-05-18 20:40:51, Heinrich Schuchardt wrote: > If !count is true, count < 4 is also true. Yep, you're right. However, gcc optimizes away the first condition. What you really got me to think about is whether 4 is the right number. I guess i shall refer to the HW documentation.

[PATCH 1/1] net: pegasus: simplify logical constraint

2016-05-18 Thread Heinrich Schuchardt
If !count is true, count < 4 is also true. Signed-off-by: Heinrich Schuchardt --- drivers/net/usb/pegasus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index 36cd7f0..9bbe0161 100644 ---

[PATCH 1/1] net: pegasus: simplify logical constraint

2016-05-18 Thread Heinrich Schuchardt
If !count is true, count < 4 is also true. Signed-off-by: Heinrich Schuchardt --- drivers/net/usb/pegasus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index 36cd7f0..9bbe0161 100644 --- a/drivers/net/usb/pegasus.c