Re: [PATCH 1/1] of: reserved_mem: fix reserve memory leak

2019-05-09 Thread pierre kuo
hi Rob: > As no one else seems to have any comments, I've applied it. Sorry for bothering you. Since I haven't see this patch on below up stream repository, "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git" if there is anything wrong about the patch, please let me know. Appreciat

Re: [PATCH 1/1] of: reserved_mem: fix reserve memory leak

2019-04-10 Thread Rob Herring
On Tue, Feb 19, 2019 at 03:45:00PM +0800, pierre Kuo wrote: > The __reserved_mem_init_node will call region specific reserved memory > init codes, but once all compatibled init codes failed, the memory region > will left in memory.reserved and cause leakage. > > Take cma reserve memory DTS for exa

Re: [PATCH 1/1] of: reserved_mem: fix reserve memory leak

2019-04-08 Thread pierre kuo
hi Rob, Marek and Frank: > > > > In this patch, we un-reserving memory ONLY if explicit compatible matching > > fail. > > That mean driver found something wrong while matching and let OS know. > > (But reserved-memory without compatible property will not be affected.) > > > > So per ur explainati

Re: [PATCH 1/1] of: reserved_mem: fix reserve memory leak

2019-04-08 Thread pierre kuo
hi Rob, Marek and Frank: > > In this patch, we un-reserving memory ONLY if explicit compatible matching > > fail. > > That mean driver found something wrong while matching and let OS know. > > (But reserved-memory without compatible property will not be affected.) > > > > So per ur explaination,

Re: [PATCH 1/1] of: reserved_mem: fix reserve memory leak

2019-03-11 Thread pierre kuo
hi Rob, Marek and Frank: > > > The __reserved_mem_init_node will call region specific reserved memory > > > init codes, but once all compatibled init codes failed, the memory region > > > will left in memory.reserved and cause leakage. > > > > > > Take cma reserve memory DTS for example, if user de

Re: [PATCH 1/1] of: reserved_mem: fix reserve memory leak

2019-03-04 Thread pierre kuo
> You should Cc the author(s) of this code. I've added Marek. Thanks ^^ The cc lists I got were from get_maintainer.pl, no matter running with of_reserved_mem.c or patch file. (with file) $ perl scripts/get_maintainer.pl --separator , --norolestats drivers/of/of_reserved_mem.c Rob Herring ,Frank

Re: [PATCH 1/1] of: reserved_mem: fix reserve memory leak

2019-03-04 Thread Rob Herring
You should Cc the author(s) of this code. I've added Marek. On Tue, Feb 19, 2019 at 1:47 AM pierre Kuo wrote: > > The __reserved_mem_init_node will call region specific reserved memory > init codes, but once all compatibled init codes failed, the memory region > will left in memory.reserved and c

[PATCH 1/1] of: reserved_mem: fix reserve memory leak

2019-02-18 Thread pierre Kuo
The __reserved_mem_init_node will call region specific reserved memory init codes, but once all compatibled init codes failed, the memory region will left in memory.reserved and cause leakage. Take cma reserve memory DTS for example, if user declare 1MB size, which is not align to (PAGE_SIZE << ma