Re: [PATCH 1/1] rtc: ds1685: correct check of day of month

2016-05-20 Thread Alexandre Belloni
Hi, On 18/05/2016 at 21:09:29 +0200, Heinrich Schuchardt wrote : > Operator ! has a higher priority than &&. > (!(mday >= 1) && (mday <= 31)) is false for mday == 32. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/rtc/rtc-ds1685.c | 4 ++-- > 1 file changed, 2

Re: [PATCH 1/1] rtc: ds1685: correct check of day of month

2016-05-20 Thread Alexandre Belloni
Hi, On 18/05/2016 at 21:09:29 +0200, Heinrich Schuchardt wrote : > Operator ! has a higher priority than &&. > (!(mday >= 1) && (mday <= 31)) is false for mday == 32. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/rtc/rtc-ds1685.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

[PATCH 1/1] rtc: ds1685: correct check of day of month

2016-05-18 Thread Heinrich Schuchardt
Operator ! has a higher priority than &&. (!(mday >= 1) && (mday <= 31)) is false for mday == 32. Signed-off-by: Heinrich Schuchardt --- drivers/rtc/rtc-ds1685.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1685.c

[PATCH 1/1] rtc: ds1685: correct check of day of month

2016-05-18 Thread Heinrich Schuchardt
Operator ! has a higher priority than &&. (!(mday >= 1) && (mday <= 31)) is false for mday == 32. Signed-off-by: Heinrich Schuchardt --- drivers/rtc/rtc-ds1685.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c index