Re: [PATCH 1/1] rtc: pcf85063: add integrity check

2021-04-19 Thread Alexandre Belloni
On 19/04/2021 20:26:42+, Gervais, Francois wrote: > > I'm not sure I get the use case because PCF85063_REG_CTRL2 should be > > initialized properly after the driver is probed anyway. The other two > > can be set from userspace once it detects the oscillator failure which > > would be better at

Re: [PATCH 1/1] rtc: pcf85063: add integrity check

2021-04-19 Thread Gervais, Francois
> I'm not sure I get the use case because PCF85063_REG_CTRL2 should be > initialized properly after the driver is probed anyway. The other two > can be set from userspace once it detects the oscillator failure which > would be better at deciding the policy anyway. Thank you for the feedback I thin

Re: [PATCH 1/1] rtc: pcf85063: add integrity check

2021-04-16 Thread Alexandre Belloni
Hi, On 11/03/2021 12:49:40-0500, Francois Gervais wrote: > Sometimes when the RTC battery is inserted, the voltage will bounce a > bit and we've seen that this can randomly flip configuration bits in > the RTC. > > For example, we've seen COF bits flips and then the output clock > frequency would

[PATCH 1/1] rtc: pcf85063: add integrity check

2021-03-11 Thread Francois Gervais
Sometimes when the RTC battery is inserted, the voltage will bounce a bit and we've seen that this can randomly flip configuration bits in the RTC. For example, we've seen COF bits flips and then the output clock frequency would not be the expected one anymore. To remediate this issue, this adds