Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-07 Thread Christoph Hellwig
On Thu, May 07, 2020 at 05:43:40PM +0200, Stefan Haberland wrote: > Not checked till now. I just was thinking about the basicapproach. > > I could either check the block_device_operations like you suggested > or I could verify that the gendisk pointer is already in our devmap > and therefor

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-07 Thread Stefan Haberland
Am 07.05.20 um 17:29 schrieb Christoph Hellwig: > On Thu, May 07, 2020 at 05:22:28PM +0200, Stefan Haberland wrote: >> OK, just thought again about your suggestion and also that >> you have already been talking about a symbol lookup I just >> have written a prototype that took your first two

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-07 Thread Christoph Hellwig
On Thu, May 07, 2020 at 05:22:28PM +0200, Stefan Haberland wrote: > OK, just thought again about your suggestion and also that > you have already been talking about a symbol lookup I just > have written a prototype that took your first two patches > as base, exports the symbol of dasd_biodasdinfo

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-07 Thread Stefan Haberland
Am 06.05.20 um 06:52 schrieb Christoph Hellwig: > > No, I mean the series that I actually sent out: > > https://lkml.org/lkml/2020/4/21/66 > https://lkml.org/lkml/2020/4/21/68 > https://lkml.org/lkml/2020/4/21/69 OK, just thought again about your suggestion and also that you have already been

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-05 Thread Christoph Hellwig
On Tue, May 05, 2020 at 05:09:56PM +0200, Stefan Haberland wrote: > OK, thanks for the hint.I did not have this in mind. And I still have > to look up how this is working at all. > But isn't this only a real issue for devices with more than 16 minors > or partitions? So it should not be a problem

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-05 Thread Stefan Haberland
Am 05.05.20 um 14:44 schrieb Christoph Hellwig: > On Mon, May 04, 2020 at 10:45:33AM +0200, Stefan Haberland wrote: >>> findthe corresponding device for example. Not sure if this is that easy. >> I did some additional research on this. >> What I could imagine: >> >> The gendisk->private_data

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-05 Thread Christoph Hellwig
On Mon, May 04, 2020 at 10:45:33AM +0200, Stefan Haberland wrote: > > findthe corresponding device for example. Not sure if this is that easy. > > I did some additional research on this. > What I could imagine: > > The gendisk->private_data pointer currently contains a pointer to > the

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-04 Thread Stefan Haberland
Am 30.04.20 um 16:02 schrieb Stefan Haberland: > Am 30.04.20 um 15:13 schrieb Christoph Hellwig: >> On Thu, Apr 30, 2020 at 01:17:54PM +0200, Stefan Haberland wrote: >>> Remove the calls to ioctl_by_bdev from the DASD partition detection code >>> to enable the removal of the specific code. >>> >>>

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-04-30 Thread Stefan Haberland
Am 30.04.20 um 15:13 schrieb Christoph Hellwig: > On Thu, Apr 30, 2020 at 01:17:54PM +0200, Stefan Haberland wrote: >> Remove the calls to ioctl_by_bdev from the DASD partition detection code >> to enable the removal of the specific code. >> >> To do so reuse the gendisk private_data pointer and

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-04-30 Thread Christoph Hellwig
On Thu, Apr 30, 2020 at 01:17:54PM +0200, Stefan Haberland wrote: > Remove the calls to ioctl_by_bdev from the DASD partition detection code > to enable the removal of the specific code. > > To do so reuse the gendisk private_data pointer and not only provide a > pointer to the devmap but provide

[PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-04-30 Thread Stefan Haberland
Remove the calls to ioctl_by_bdev from the DASD partition detection code to enable the removal of the specific code. To do so reuse the gendisk private_data pointer and not only provide a pointer to the devmap but provide a new structure containing a pointer to the devmap as well as all required