Re: [PATCH 1/1] s390/net: Deletion of unnecessary checks before two function calls

2015-01-19 Thread Brian Norris
I went digging through some of Markus's old patch history, and noticed this... On Mon, Nov 03, 2014 at 12:50:59PM +0300, Dan Carpenter wrote: > This one is buggy. > > I'm sorry, but please stop sending these. I'm tending to concur. > For kfree(), at least we all know that kfree() accepts NULL p

Re: [PATCH 1/1] s390/net: Deletion of unnecessary checks before two function calls

2014-11-03 Thread Ursula Braun
I agree with your proposed debug_unregister() changes, but not with your kfree_fsm() change. Regards, Ursula Braun On Fri, 2014-10-31 at 18:40 +0100, SF Markus Elfring wrote: > The functions debug_unregister() and kfree_fsm() test whether their argument > is NULL and then return immediately. Thus

Re: [PATCH 1/1] s390/net: Deletion of unnecessary checks before two function calls

2014-11-03 Thread Dan Carpenter
This one is buggy. I'm sorry, but please stop sending these. For kfree(), at least we all know that kfree() accepts NULL pointer. But for this one: 1) I don't know what the functions do so I have to look at the code. 2) It's in a arch that I don't compile so cscope isn't set up meaning it's ha

Re: [PATCH 1/1] s390/net: Deletion of unnecessary checks before two function calls

2014-10-31 Thread SF Markus Elfring
The functions debug_unregister() and kfree_fsm() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/s390/net/claw.c | 6 ++ dr