Re: [PATCH 1/1] s390: vfio-ap: include for test_facility()

2018-11-16 Thread Petr Tesarik
On Fri, 16 Nov 2018 13:20:33 +0100 Halil Pasic wrote: > On Fri, 16 Nov 2018 11:47:48 +0100 > Petr Tesarik wrote: > > > The driver uses test_facility(), but does not include the > > corresponding include file explicitly. The driver currently builds > > only thanks to the following include chain:

Re: [PATCH 1/1] s390: vfio-ap: include for test_facility()

2018-11-16 Thread Halil Pasic
On Fri, 16 Nov 2018 11:47:48 +0100 Petr Tesarik wrote: > The driver uses test_facility(), but does not include the > corresponding include file explicitly. The driver currently builds > only thanks to the following include chain: > > vfio_ap_drv.c > > > > >

Re: [PATCH 1/1] s390: vfio-ap: include for test_facility()

2018-11-16 Thread Christian Borntraeger
On 11/16/2018 11:47 AM, Petr Tesarik wrote: > The driver uses test_facility(), but does not include the > corresponding include file explicitly. The driver currently builds > only thanks to the following include chain: > > vfio_ap_drv.c > > > > > >

Re: [PATCH 1/1] s390: vfio-ap: include for test_facility()

2018-11-16 Thread Cornelia Huck
On Fri, 16 Nov 2018 11:47:48 +0100 Petr Tesarik wrote: > The driver uses test_facility(), but does not include the > corresponding include file explicitly. The driver currently builds > only thanks to the following include chain: > > vfio_ap_drv.c > > > > >

[PATCH 1/1] s390: vfio-ap: include for test_facility()

2018-11-16 Thread Petr Tesarik
The driver uses test_facility(), but does not include the corresponding include file explicitly. The driver currently builds only thanks to the following include chain: vfio_ap_drv.c Files should not rely on such fragile implicit inclu