Re: [PATCH 1/1] scsi: sd: use max_xfer_blocks for set rw_max if max_xfer_blocks is available

2021-01-26 Thread Changheun Lee
> Hello Changheun! > > > I want to discuss using max_xfer_blocks instead of opt_xfer_blocks as > > a optional. For example, device reports opt_xfer_blocks is 512KB and > > 1MB as a max_xfer_blocks too. Currently rw_max is set with 512KB only. > > Because that's what the device asks for. If a

Re: [PATCH 1/1] scsi: sd: use max_xfer_blocks for set rw_max if max_xfer_blocks is available

2021-01-26 Thread Martin K. Petersen
Hello Changheun! > I want to discuss using max_xfer_blocks instead of opt_xfer_blocks as > a optional. For example, device reports opt_xfer_blocks is 512KB and > 1MB as a max_xfer_blocks too. Currently rw_max is set with 512KB only. Because that's what the device asks for. If a device

Re: [PATCH 1/1] scsi: sd: use max_xfer_blocks for set rw_max if max_xfer_blocks is available

2021-01-26 Thread Changheun Lee
> Damien, > > >> How about set larger valid value between sdkp->max_xfer_blocks, > >> and sdkp->opt_xfer_blocks to rw_max? > > > > Again, if your device reports an opt_xfer_blocks value that is too > > small for its own good, that is a problem with this device. > > Correct. It is very much

Re: [PATCH 1/1] scsi: sd: use max_xfer_blocks for set rw_max if max_xfer_blocks is available

2021-01-22 Thread Martin K. Petersen
Damien, >> How about set larger valid value between sdkp->max_xfer_blocks, >> and sdkp->opt_xfer_blocks to rw_max? > > Again, if your device reports an opt_xfer_blocks value that is too > small for its own good, that is a problem with this device. Correct. It is very much intentional that we

Re: [PATCH 1/1] scsi: sd: use max_xfer_blocks for set rw_max if max_xfer_blocks is available

2021-01-21 Thread Damien Le Moal
On 2021/01/22 16:24, Changheun Lee wrote: >> On 2021/01/20 15:45, Manjong Lee wrote: >>> Add recipients for more reviews. >> >> Please resend instead of replying to your own patch. The reply quoting >> corrupts >> the patch. >> >> The patch title is very long. >> >>> SCSI device has

Re: [PATCH 1/1] scsi: sd: use max_xfer_blocks for set rw_max if max_xfer_blocks is available

2021-01-21 Thread Changheun Lee
> On 2021/01/20 15:45, Manjong Lee wrote: > > Add recipients for more reviews. > > Please resend instead of replying to your own patch. The reply quoting > corrupts > the patch. > > The patch title is very long. > > > > >> SCSI device has max_xfer_size and opt_xfer_size, > >> but current

Re: [PATCH 1/1] scsi: sd: use max_xfer_blocks for set rw_max if max_xfer_blocks is available

2021-01-20 Thread Damien Le Moal
On 2021/01/20 15:45, Manjong Lee wrote: > Add recipients for more reviews. Please resend instead of replying to your own patch. The reply quoting corrupts the patch. The patch title is very long. > >> SCSI device has max_xfer_size and opt_xfer_size, >> but current kernel uses only

RE: [PATCH 1/1] scsi: sd: use max_xfer_blocks for set rw_max if max_xfer_blocks is available

2021-01-19 Thread Manjong Lee
Add recipients for more reviews. >SCSI device has max_xfer_size and opt_xfer_size, >but current kernel uses only opt_xfer_size. > >It causes the limitation on setting IO chunk size, >although it can support larger one. > >So, I propose this patch to use max_xfer_size in case it has valid value.

[PATCH 1/1] scsi: sd: use max_xfer_blocks for set rw_max if max_xfer_blocks is available

2021-01-12 Thread Manjong Lee
SCSI device has max_xfer_size and opt_xfer_size, but current kernel uses only opt_xfer_size. It causes the limitation on setting IO chunk size, although it can support larger one. So, I propose this patch to use max_xfer_size in case it has valid value. It can support to use the larger chunk IO