Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-07-03 Thread Fathi Boudra
On 1 July 2017 at 04:48, Michael Ellerman wrote: > Fathi Boudra writes: > >> On 30 June 2017 at 05:20, Bamvor Zhang Jian >> wrote: >>> On 29 June 2017 at 19:39, Fathi Boudra wrote: On 29

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-07-03 Thread Fathi Boudra
On 1 July 2017 at 04:48, Michael Ellerman wrote: > Fathi Boudra writes: > >> On 30 June 2017 at 05:20, Bamvor Zhang Jian >> wrote: >>> On 29 June 2017 at 19:39, Fathi Boudra wrote: On 29 June 2017 at 12:01, Michael Ellerman wrote: > Fathi Boudra writes: > >> Fix hardcoded

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-30 Thread Michael Ellerman
Fathi Boudra writes: > On 30 June 2017 at 05:20, Bamvor Zhang Jian > wrote: >> On 29 June 2017 at 19:39, Fathi Boudra wrote: >>> On 29 June 2017 at 12:01, Michael Ellerman wrote: Fathi

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-30 Thread Michael Ellerman
Fathi Boudra writes: > On 30 June 2017 at 05:20, Bamvor Zhang Jian > wrote: >> On 29 June 2017 at 19:39, Fathi Boudra wrote: >>> On 29 June 2017 at 12:01, Michael Ellerman wrote: Fathi Boudra writes: > Fix hardcoded and misplaced libmount headers. Use pkg-config instead to

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-30 Thread Michael Ellerman
Fathi Boudra writes: > On 29 June 2017 at 12:01, Michael Ellerman wrote: >> Fathi Boudra writes: >> >>> Fix hardcoded and misplaced libmount headers. Use pkg-config instead to >>> figure out CFLAGS/LDLIBS, fixing also their

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-30 Thread Michael Ellerman
Fathi Boudra writes: > On 29 June 2017 at 12:01, Michael Ellerman wrote: >> Fathi Boudra writes: >> >>> Fix hardcoded and misplaced libmount headers. Use pkg-config instead to >>> figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation. >> >> Can you explain how it fixes the

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-29 Thread Fathi Boudra
On 30 June 2017 at 05:20, Bamvor Zhang Jian wrote: > On 29 June 2017 at 19:39, Fathi Boudra wrote: >> On 29 June 2017 at 12:01, Michael Ellerman wrote: >>> Fathi Boudra writes: >>> Fix

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-29 Thread Fathi Boudra
On 30 June 2017 at 05:20, Bamvor Zhang Jian wrote: > On 29 June 2017 at 19:39, Fathi Boudra wrote: >> On 29 June 2017 at 12:01, Michael Ellerman wrote: >>> Fathi Boudra writes: >>> Fix hardcoded and misplaced libmount headers. Use pkg-config instead to figure out CFLAGS/LDLIBS,

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-29 Thread Bamvor Zhang Jian
On 29 June 2017 at 19:39, Fathi Boudra wrote: > On 29 June 2017 at 12:01, Michael Ellerman wrote: >> Fathi Boudra writes: >> >>> Fix hardcoded and misplaced libmount headers. Use pkg-config instead to >>> figure out

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-29 Thread Bamvor Zhang Jian
On 29 June 2017 at 19:39, Fathi Boudra wrote: > On 29 June 2017 at 12:01, Michael Ellerman wrote: >> Fathi Boudra writes: >> >>> Fix hardcoded and misplaced libmount headers. Use pkg-config instead to >>> figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation. >> >> Can you

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-29 Thread Fathi Boudra
On 29 June 2017 at 12:01, Michael Ellerman wrote: > Fathi Boudra writes: > >> Fix hardcoded and misplaced libmount headers. Use pkg-config instead to >> figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation. > > Can you explain how

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-29 Thread Fathi Boudra
On 29 June 2017 at 12:01, Michael Ellerman wrote: > Fathi Boudra writes: > >> Fix hardcoded and misplaced libmount headers. Use pkg-config instead to >> figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation. > > Can you explain how it fixes the values for cross-compilation?

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-29 Thread Michael Ellerman
Fathi Boudra writes: > Fix hardcoded and misplaced libmount headers. Use pkg-config instead to > figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation. Can you explain how it fixes the values for cross-compilation? cheers

Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-29 Thread Michael Ellerman
Fathi Boudra writes: > Fix hardcoded and misplaced libmount headers. Use pkg-config instead to > figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation. Can you explain how it fixes the values for cross-compilation? cheers

[PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-29 Thread Fathi Boudra
Fix hardcoded and misplaced libmount headers. Use pkg-config instead to figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation. If pkg-config isn't installed, it gives an error (command not found) and gpio test will fail to build because it won't be able to find the headers or

[PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

2017-06-29 Thread Fathi Boudra
Fix hardcoded and misplaced libmount headers. Use pkg-config instead to figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation. If pkg-config isn't installed, it gives an error (command not found) and gpio test will fail to build because it won't be able to find the headers or