Re: [greybus-dev] [PATCH 1/1] staging: greybus: Added do - while in multi statement macro

2021-02-15 Thread Dan Carpenter
On Thu, Feb 11, 2021 at 03:40:39PM +0530, Viresh Kumar wrote: > On 11-02-21, 11:00, Greg KH wrote: > > On Thu, Feb 11, 2021 at 03:24:44PM +0530, Hemansh Agnihotri wrote: > > > This patch add fixes an checkpatch error for "Macros with multiple > > > statements > > > should be enclosed in a do -

Re: [PATCH 1/1] staging: greybus: Added do - while in multi statement macro

2021-02-11 Thread kernel test robot
Hi Hemansh, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Hemansh-Agnihotri/staging-greybus-Added-do-while-in-multi-statement-macro/20210211-175717 base:

Re: [greybus-dev] [PATCH 1/1] staging: greybus: Added do - while in multi statement macro

2021-02-11 Thread Viresh Kumar
On 11-02-21, 11:00, Greg KH wrote: > On Thu, Feb 11, 2021 at 03:24:44PM +0530, Hemansh Agnihotri wrote: > > This patch add fixes an checkpatch error for "Macros with multiple > > statements > > should be enclosed in a do - while loop" > > > > Signed-off-by: Hemansh Agnihotri > > Any reason you

Re: [PATCH 1/1] staging: greybus: Added do - while in multi statement macro

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 03:24:44PM +0530, Hemansh Agnihotri wrote: > This patch add fixes an checkpatch error for "Macros with multiple statements > should be enclosed in a do - while loop" > > Signed-off-by: Hemansh Agnihotri Any reason you didn't test-build your patch before sending it out?

[PATCH 1/1] staging: greybus: Added do - while in multi statement macro

2021-02-11 Thread Hemansh Agnihotri
This patch add fixes an checkpatch error for "Macros with multiple statements should be enclosed in a do - while loop" Signed-off-by: Hemansh Agnihotri --- drivers/staging/greybus/loopback.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git