Re: [PATCH 1/1] task_work: Add local_irq_enable() into task_work_run()

2012-10-13 Thread Al Viro
On Sat, Oct 13, 2012 at 10:59:25PM +1300, Michael Cree wrote: > Any chance that we could have the fixes backported to the stable queue, in > particular to the 3,2 kernel? We should then be able to run the Debian built > SMP kernel on the autobuilders at Debian-Ports rather than having to run a

Re: [PATCH 1/1] task_work: Add local_irq_enable() into task_work_run()

2012-10-13 Thread Thorsten Kranzkowski
On Sat, Oct 13, 2012 at 10:09:36AM +0900, Linus Torvalds wrote: > On Sat, Oct 13, 2012 at 1:03 AM, Oleg Nesterov wrote: > > arch/alpha and probably some other architectures call > > do_notify_resume()->task_work_run() with irqs disabled. > > I'm going to ignore this patch because I *hope* it is u

Re: [PATCH 1/1] task_work: Add local_irq_enable() into task_work_run()

2012-10-13 Thread Michael Cree
On Sat 13 October 2012 14:09:36 Linus Torvalds wrote: > On Sat, Oct 13, 2012 at 1:03 AM, Oleg Nesterov wrote: > > arch/alpha and probably some other architectures call > > do_notify_resume()->task_work_run() with irqs disabled. > > I'm going to ignore this patch because I *hope* it is unnecessary

Re: [PATCH 1/1] task_work: Add local_irq_enable() into task_work_run()

2012-10-12 Thread Al Viro
On Sat, Oct 13, 2012 at 10:09:36AM +0900, Linus Torvalds wrote: > On Sat, Oct 13, 2012 at 1:03 AM, Oleg Nesterov wrote: > > arch/alpha and probably some other architectures call > > do_notify_resume()->task_work_run() with irqs disabled. > > I'm going to ignore this patch because I *hope* it is u

Re: [PATCH 1/1] task_work: Add local_irq_enable() into task_work_run()

2012-10-12 Thread Linus Torvalds
On Sat, Oct 13, 2012 at 1:03 AM, Oleg Nesterov wrote: > arch/alpha and probably some other architectures call > do_notify_resume()->task_work_run() with irqs disabled. I'm going to ignore this patch because I *hope* it is unnecessary after the pull from Al that I just did. But if that turns out

[PATCH 1/1] task_work: Add local_irq_enable() into task_work_run()

2012-10-12 Thread Oleg Nesterov
arch/alpha and probably some other architectures call do_notify_resume()->task_work_run() with irqs disabled. This wasn't noticed because key_replace_session_keyring() and then task_work_run() did spin_lock_irq() + spin_unlock_irq(), but this sequence was removed by 9da33de6. Add local_irq_enable