Re: [PATCH 1/1] thinkpad-acpi: kill hotkey_thread_mutex

2013-03-26 Thread Rafael J. Wysocki
On Tuesday, March 26, 2013 02:09:19 PM Oleg Nesterov wrote: > On 03/26, Rafael J. Wysocki wrote: > > > > On Thursday, March 07, 2013 06:53:59 PM Oleg Nesterov wrote: > > > hotkey_kthread() does try_to_freeze() under hotkey_thread_mutex. > > > > > > We can simply kill this mutex, hotkey_poll_stop_sy

Re: [PATCH 1/1] thinkpad-acpi: kill hotkey_thread_mutex

2013-03-26 Thread Oleg Nesterov
On 03/26, Rafael J. Wysocki wrote: > > On Thursday, March 07, 2013 06:53:59 PM Oleg Nesterov wrote: > > hotkey_kthread() does try_to_freeze() under hotkey_thread_mutex. > > > > We can simply kill this mutex, hotkey_poll_stop_sync() does not need > > to serialize with hotkey_kthread(). When kthread_

Re: [PATCH 1/1] thinkpad-acpi: kill hotkey_thread_mutex

2013-03-26 Thread Rafael J. Wysocki
On Thursday, March 07, 2013 06:53:59 PM Oleg Nesterov wrote: > hotkey_kthread() does try_to_freeze() under hotkey_thread_mutex. > > We can simply kill this mutex, hotkey_poll_stop_sync() does not need > to serialize with hotkey_kthread(). When kthread_stop() returns the > thread is already dead, i

Re: [PATCH 1/1] thinkpad-acpi: kill hotkey_thread_mutex

2013-03-09 Thread Henrique de Moraes Holschuh
On Thu, 07 Mar 2013, Mandeep Singh Baines wrote: > On Thu, Mar 7, 2013 at 9:53 AM, Oleg Nesterov wrote: > > hotkey_kthread() does try_to_freeze() under hotkey_thread_mutex. > > > > We can simply kill this mutex, hotkey_poll_stop_sync() does not need > > to serialize with hotkey_kthread(). When kth

Re: [PATCH 1/1] thinkpad-acpi: kill hotkey_thread_mutex

2013-03-07 Thread Mandeep Singh Baines
On Thu, Mar 7, 2013 at 9:53 AM, Oleg Nesterov wrote: > hotkey_kthread() does try_to_freeze() under hotkey_thread_mutex. > > We can simply kill this mutex, hotkey_poll_stop_sync() does not need > to serialize with hotkey_kthread(). When kthread_stop() returns the > thread is already dead, it called

[PATCH 1/1] thinkpad-acpi: kill hotkey_thread_mutex

2013-03-07 Thread Oleg Nesterov
hotkey_kthread() does try_to_freeze() under hotkey_thread_mutex. We can simply kill this mutex, hotkey_poll_stop_sync() does not need to serialize with hotkey_kthread(). When kthread_stop() returns the thread is already dead, it called do_exit()->complete_vfork_done(). Reported-by: Artem Savkov