Re: [PATCH 1/1] usermodehelper: check subprocess_info->path != NULL

2013-05-16 Thread Oleg Nesterov
On 05/16, Lucas De Marchi wrote: > > > > > - kill or justify ->path[0] check > > I'm not sure about this, it's already there before my refactor and I > don't think it makes any good. From modprobe pespective, I'd say it > would be better to give an error than say everything went ok. Agreed

Re: [PATCH 1/1] usermodehelper: check subprocess_info->path != NULL

2013-05-16 Thread Lucas De Marchi
Hi Oleg, On Thu, May 16, 2013 at 12:43 PM, Oleg Nesterov wrote: > argv_split(empty_or_all_spaces) happily succeeds, it simply returns > argc == 0 and argv[0] == NULL. Change call_usermodehelper_exec() to > check sub_info->path != NULL to avoid the crash. > > This is the minimal fix, todo: > >

[PATCH 1/1] usermodehelper: check subprocess_info->path != NULL

2013-05-16 Thread Oleg Nesterov
argv_split(empty_or_all_spaces) happily succeeds, it simply returns argc == 0 and argv[0] == NULL. Change call_usermodehelper_exec() to check sub_info->path != NULL to avoid the crash. This is the minimal fix, todo: - perhaps we should change argv_split() to return NULL or chang