RE: [External] Re: [PATCH 1/1] workqueue: Remove redundant assignment

2020-11-04 Thread Adrian Huang12
Hi Jiangshan, > -Original Message- > From: Lai Jiangshan > Sent: Tuesday, November 3, 2020 12:35 PM > To: Adrian Huang > Cc: Tejun Heo ; LKML ; Adrian > Huang12 > Subject: [External] Re: [PATCH 1/1] workqueue: Remove redundant assignment > > Hello, Adrian &g

Re: [PATCH 1/1] workqueue: Remove redundant assignment

2020-11-02 Thread Lai Jiangshan
Hello, Adrian I believe the pool->node is being used as a node hint before workqueue_init() for allocating memory. It is useful when it is correct. I think it is better to init it early unless there is a bug about it in this early stage reported (on same archs). Thanks Lai. On Sun, Nov 1, 2020

[PATCH 1/1] workqueue: Remove redundant assignment

2020-11-01 Thread Adrian Huang
From: Adrian Huang The member 'node' of worker_pool struct (per_cpu worker_pool) is assigned in workqueue_init_early() and workqueue_init(). Commit 2186d9f940b6 ("workqueue: move wq_numa_init() to workqueue_init()") fixes an issue by moving wq_numa_init() to workqueue_init() in order to get the v