Re: [PATCH 1/1] x86, acpi: Fix wrong checking condition in acpi_register_lapic().

2013-07-23 Thread Tang Chen
On 07/23/2013 03:39 PM, Ingo Molnar wrote: * Tang Chen wrote: We wanted to check if the acpi id is out of range. It should be: if (id>= (MAX_LOCAL_APIC)). Does this have any practical impact, or can it wait until v3.12? I haven't tested out any impact now, just found it when

Re: [PATCH 1/1] x86, acpi: Fix wrong checking condition in acpi_register_lapic().

2013-07-23 Thread Ingo Molnar
* Tang Chen wrote: > We wanted to check if the acpi id is out of range. It should be: > if (id >= (MAX_LOCAL_APIC)). Does this have any practical impact, or can it wait until v3.12? > Signed-off-by: Tang Chen > --- > arch/x86/kernel/acpi/boot.c |2 +- > 1 file changed, 1

Re: [PATCH 1/1] x86, acpi: Fix wrong checking condition in acpi_register_lapic().

2013-07-23 Thread Ingo Molnar
* Tang Chen tangc...@cn.fujitsu.com wrote: We wanted to check if the acpi id is out of range. It should be: if (id = (MAX_LOCAL_APIC)). Does this have any practical impact, or can it wait until v3.12? Signed-off-by: Tang Chen tangc...@cn.fujitsu.com --- arch/x86/kernel/acpi/boot.c

Re: [PATCH 1/1] x86, acpi: Fix wrong checking condition in acpi_register_lapic().

2013-07-23 Thread Tang Chen
On 07/23/2013 03:39 PM, Ingo Molnar wrote: * Tang Chentangc...@cn.fujitsu.com wrote: We wanted to check if the acpi id is out of range. It should be: if (id= (MAX_LOCAL_APIC)). Does this have any practical impact, or can it wait until v3.12? I haven't tested out any impact now,

RE: [PATCH 1/1] x86, acpi: Fix wrong checking condition in acpi_register_lapic().

2013-07-22 Thread Brown, Len
Reviewed-by: Len Brown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 1/1] x86, acpi: Fix wrong checking condition in acpi_register_lapic().

2013-07-22 Thread Tang Chen
We wanted to check if the acpi id is out of range. It should be: if (id >= (MAX_LOCAL_APIC)). Signed-off-by: Tang Chen --- arch/x86/kernel/acpi/boot.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c index

[PATCH 1/1] x86, acpi: Fix wrong checking condition in acpi_register_lapic().

2013-07-22 Thread Tang Chen
We wanted to check if the acpi id is out of range. It should be: if (id = (MAX_LOCAL_APIC)). Signed-off-by: Tang Chen tangc...@cn.fujitsu.com --- arch/x86/kernel/acpi/boot.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/acpi/boot.c

RE: [PATCH 1/1] x86, acpi: Fix wrong checking condition in acpi_register_lapic().

2013-07-22 Thread Brown, Len
Reviewed-by: Len Brown len.br...@intel.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/