Re: [PATCH 1/1] x86/iommu: fix incorrect bit operations in setting values

2014-11-14 Thread Li, ZhenHua
1st step shows we should NOT disable the iommu when it is already enabled. But current code does disable-enable. So there is still works to do. The original kernel does a disable and re-enable , Bill's patchset removed the disable operation. I think step 2 is necessary, because when the d

Re: [PATCH 1/1] x86/iommu: fix incorrect bit operations in setting values

2014-11-13 Thread Li, ZhenHua
On 11/13/2014 09:37 PM, Baoquan He wrote: On 11/13/14 at 05:06pm, Li, ZhenHua wrote: Minfei, Thanks for your testing. On my system, I got error messages: [8.019096] usb usb2: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [8.019617] dmar: DRHD: handling fault status reg 102 [

Re: [PATCH 1/1] x86/iommu: fix incorrect bit operations in setting values

2014-11-13 Thread Baoquan He
On 11/13/14 at 05:06pm, Li, ZhenHua wrote: > Minfei, > Thanks for your testing. > On my system, I got error messages: > > [8.019096] usb usb2: New USB device strings: Mfr=3, Product=2, > SerialNumber=1 > [8.019617] dmar: DRHD: handling fault status reg 102 > [8.019621] dmar: DMAR:[DMA

Re: [PATCH 1/1] x86/iommu: fix incorrect bit operations in setting values

2014-11-13 Thread Li, ZhenHua
Minfei, Thanks for your testing. On my system, I got error messages: [8.019096] usb usb2: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [8.019617] dmar: DRHD: handling fault status reg 102 [8.019621] dmar: DMAR:[DMA Read] Request device [01:00.0] fault addr fff6a000 [

Re: [PATCH 1/1] x86/iommu: fix incorrect bit operations in setting values

2014-11-12 Thread Minfei Huang
The kdump starts 2nd kernel without any error message when I use 3.18.0-rc4 merged last 6 patchs. The following is the message which 2nd kernel prints during booting. Patchset: 0001-iommu-vt-d-Update-iommu_attach_domain-and-its-caller.patch 0002-iommu-vt-d-Items-required-for-kdump.

Re: [PATCH 1/1] x86/iommu: fix incorrect bit operations in setting values

2014-11-06 Thread Joerg Roedel
On Wed, Nov 05, 2014 at 03:30:19PM +0800, Li, Zhen-Hua wrote: > Signed-off-by: Li, Zhen-Hua > --- > drivers/iommu/intel-iommu.c | 2 ++ > 1 file changed, 2 insertions(+) Applied, thanks Li. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to maj

Re: [PATCH 1/1] x86/iommu: fix incorrect bit operations in setting values

2014-11-04 Thread Li, ZhenHua
Hi Joerg, While debugging Bill's patches, I found this problem: When copying iommu data from old kernel to the kdump kernel, the original function context_set_address_root() may cause kdump kernel using incorrect address root value. So I created this patch to fix it. Zhenhua On 11/05/2014 0

[PATCH 1/1] x86/iommu: fix incorrect bit operations in setting values

2014-11-04 Thread Li, Zhen-Hua
The function context_set_address_root() and set_root_value are setting new address in a wrong way, and this patch is trying to fix this problem. According to Intel Vt-d specs(Feb 2011, Revision 1.3), Chapter 9.1 and 9.2, field ctp in root entry is using bits 12:63, field asr in context entry is us