Re: [PATCH 1/1] zram: better utilization of zram swap space

2017-12-10 Thread Sergey Senozhatsky
On (12/11/17 09:16), Minchan Kim wrote: [..] > I agree. zram shouldn't be aware of allocator internal. > It would be better for zram to use *int zs_max_zpage_size(struct zs_pool > *pool)* > to set up max_zpage_size. > Let's hide the allocator's detail to the exported function. Hi Minchan, cool

Re: [PATCH 1/1] zram: better utilization of zram swap space

2017-12-10 Thread Sergey Senozhatsky
On (12/11/17 09:16), Minchan Kim wrote: [..] > I agree. zram shouldn't be aware of allocator internal. > It would be better for zram to use *int zs_max_zpage_size(struct zs_pool > *pool)* > to set up max_zpage_size. > Let's hide the allocator's detail to the exported function. Hi Minchan, cool

Re: [PATCH 1/1] zram: better utilization of zram swap space

2017-12-10 Thread Minchan Kim
Hi Gopi and Sergey, On Thu, Dec 07, 2017 at 05:45:10PM +0900, Sergey Senozhatsky wrote: > On (12/07/17 13:52), Gopi Sai Teja wrote: > > If the length of the compressed page is greater than 75% of the PAGE_SIZE, > > then the page is stored uncompressed in zram space. Zram space utilization > > is

Re: [PATCH 1/1] zram: better utilization of zram swap space

2017-12-10 Thread Minchan Kim
Hi Gopi and Sergey, On Thu, Dec 07, 2017 at 05:45:10PM +0900, Sergey Senozhatsky wrote: > On (12/07/17 13:52), Gopi Sai Teja wrote: > > If the length of the compressed page is greater than 75% of the PAGE_SIZE, > > then the page is stored uncompressed in zram space. Zram space utilization > > is

Re: [PATCH 1/1] zram: better utilization of zram swap space

2017-12-07 Thread Sergey Senozhatsky
On (12/07/17 17:45), Sergey Senozhatsky wrote: [..] > On (12/07/17 13:52), Gopi Sai Teja wrote: > > If the length of the compressed page is greater than 75% of the PAGE_SIZE, > > then the page is stored uncompressed in zram space. Zram space utilization > > is improved if the threshold is 80%(5

Re: [PATCH 1/1] zram: better utilization of zram swap space

2017-12-07 Thread Sergey Senozhatsky
On (12/07/17 17:45), Sergey Senozhatsky wrote: [..] > On (12/07/17 13:52), Gopi Sai Teja wrote: > > If the length of the compressed page is greater than 75% of the PAGE_SIZE, > > then the page is stored uncompressed in zram space. Zram space utilization > > is improved if the threshold is 80%(5

Re: [PATCH 1/1] zram: better utilization of zram swap space

2017-12-07 Thread Sergey Senozhatsky
On (12/07/17 13:52), Gopi Sai Teja wrote: > If the length of the compressed page is greater than 75% of the PAGE_SIZE, > then the page is stored uncompressed in zram space. Zram space utilization > is improved if the threshold is 80%(5 compressed pages can be stored in > 4 pages). > > If the

Re: [PATCH 1/1] zram: better utilization of zram swap space

2017-12-07 Thread Sergey Senozhatsky
On (12/07/17 13:52), Gopi Sai Teja wrote: > If the length of the compressed page is greater than 75% of the PAGE_SIZE, > then the page is stored uncompressed in zram space. Zram space utilization > is improved if the threshold is 80%(5 compressed pages can be stored in > 4 pages). > > If the

[PATCH 1/1] zram: better utilization of zram swap space

2017-12-07 Thread Gopi Sai Teja
If the length of the compressed page is greater than 75% of the PAGE_SIZE, then the page is stored uncompressed in zram space. Zram space utilization is improved if the threshold is 80%(5 compressed pages can be stored in 4 pages). If the compressed length is greater than 3068 and less than 3261,

[PATCH 1/1] zram: better utilization of zram swap space

2017-12-07 Thread Gopi Sai Teja
If the length of the compressed page is greater than 75% of the PAGE_SIZE, then the page is stored uncompressed in zram space. Zram space utilization is improved if the threshold is 80%(5 compressed pages can be stored in 4 pages). If the compressed length is greater than 3068 and less than 3261,