Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-15 Thread Lai Jiangshan
On 07/15/2014 05:42 AM, Thomas Gleixner wrote: > On Tue, 15 Jul 2014, Lai Jiangshan wrote: >> On 07/14/2014 11:33 PM, Thomas Gleixner wrote: >>> On Mon, 14 Jul 2014, Tejun Heo wrote: >>> Hello, On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote: > It is said in the

Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-15 Thread Lai Jiangshan
On 07/15/2014 05:42 AM, Thomas Gleixner wrote: On Tue, 15 Jul 2014, Lai Jiangshan wrote: On 07/14/2014 11:33 PM, Thomas Gleixner wrote: On Mon, 14 Jul 2014, Tejun Heo wrote: Hello, On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote: It is said in the document that the timer

Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-14 Thread Lai Jiangshan
On 07/15/2014 05:42 AM, Thomas Gleixner wrote: > On Tue, 15 Jul 2014, Lai Jiangshan wrote: >> On 07/14/2014 11:33 PM, Thomas Gleixner wrote: >>> On Mon, 14 Jul 2014, Tejun Heo wrote: >>> Hello, On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote: > It is said in the

Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-14 Thread Thomas Gleixner
On Tue, 15 Jul 2014, Lai Jiangshan wrote: > On 07/14/2014 11:33 PM, Thomas Gleixner wrote: > > On Mon, 14 Jul 2014, Tejun Heo wrote: > > > >> Hello, > >> > >> On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote: > >>> It is said in the document that the timer which is being > >>>

Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-14 Thread Lai Jiangshan
On 07/14/2014 11:33 PM, Thomas Gleixner wrote: > On Mon, 14 Jul 2014, Tejun Heo wrote: > >> Hello, >> >> On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote: >>> It is said in the document that the timer which is being >>> deleted by del_timer_sync() should not be restarted: >>>

Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-14 Thread Thomas Gleixner
On Mon, 14 Jul 2014, Tejun Heo wrote: > Hello, > > On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote: > > It is said in the document that the timer which is being > > deleted by del_timer_sync() should not be restarted: > > Synchronization rules: Callers must prevent restarting of

Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-14 Thread Tejun Heo
Hello, On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote: > It is said in the document that the timer which is being > deleted by del_timer_sync() should not be restarted: > Synchronization rules: Callers must prevent restarting of > the timer, otherwise this function is

[PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-14 Thread Lai Jiangshan
It is said in the document that the timer which is being deleted by del_timer_sync() should not be restarted: Synchronization rules: Callers must prevent restarting of the timer, otherwise this function is meaningless. Repeating timer may cause the del_timer_sync() spin longer, or even spin

[PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-14 Thread Lai Jiangshan
It is said in the document that the timer which is being deleted by del_timer_sync() should not be restarted: Synchronization rules: Callers must prevent restarting of the timer, otherwise this function is meaningless. Repeating timer may cause the del_timer_sync() spin longer, or even spin

Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-14 Thread Tejun Heo
Hello, On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote: It is said in the document that the timer which is being deleted by del_timer_sync() should not be restarted: Synchronization rules: Callers must prevent restarting of the timer, otherwise this function is meaningless.

Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-14 Thread Thomas Gleixner
On Mon, 14 Jul 2014, Tejun Heo wrote: Hello, On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote: It is said in the document that the timer which is being deleted by del_timer_sync() should not be restarted: Synchronization rules: Callers must prevent restarting of the

Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-14 Thread Lai Jiangshan
On 07/14/2014 11:33 PM, Thomas Gleixner wrote: On Mon, 14 Jul 2014, Tejun Heo wrote: Hello, On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote: It is said in the document that the timer which is being deleted by del_timer_sync() should not be restarted: Synchronization rules:

Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-14 Thread Thomas Gleixner
On Tue, 15 Jul 2014, Lai Jiangshan wrote: On 07/14/2014 11:33 PM, Thomas Gleixner wrote: On Mon, 14 Jul 2014, Tejun Heo wrote: Hello, On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote: It is said in the document that the timer which is being deleted by del_timer_sync()

Re: [PATCH 1/1 V2] workqueue: remove the del_timer_sync()s in maybe_create_worker()

2014-07-14 Thread Lai Jiangshan
On 07/15/2014 05:42 AM, Thomas Gleixner wrote: On Tue, 15 Jul 2014, Lai Jiangshan wrote: On 07/14/2014 11:33 PM, Thomas Gleixner wrote: On Mon, 14 Jul 2014, Tejun Heo wrote: Hello, On Mon, Jul 14, 2014 at 04:13:21PM +0800, Lai Jiangshan wrote: It is said in the document that the timer