Re: [PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions

2015-05-05 Thread Fabian Frederick
> On 04 May 2015 at 23:30 "Rafael J. Wysocki" wrote: > > > On Saturday, May 02, 2015 06:01:21 PM Fabian Frederick wrote: > > EXPORT macro must be placed directly after functions. > > See Documentation/CodingStyle Chapter 6 > > Well, why is this change an improvement? > > Yes, it makes an old

Re: [PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions

2015-05-05 Thread Fabian Frederick
On 04 May 2015 at 23:30 Rafael J. Wysocki r...@rjwysocki.net wrote: On Saturday, May 02, 2015 06:01:21 PM Fabian Frederick wrote: EXPORT macro must be placed directly after functions. See Documentation/CodingStyle Chapter 6 Well, why is this change an improvement? Yes, it makes an

Re: [PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions

2015-05-04 Thread Rafael J. Wysocki
On Saturday, May 02, 2015 06:01:21 PM Fabian Frederick wrote: > EXPORT macro must be placed directly after functions. > See Documentation/CodingStyle Chapter 6 Well, why is this change an improvement? Yes, it makes an old file follow the new(er) Documentation/CodingStyl, but what exactly is the

Re: [PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions

2015-05-04 Thread Rafael J. Wysocki
On Saturday, May 02, 2015 06:01:21 PM Fabian Frederick wrote: EXPORT macro must be placed directly after functions. See Documentation/CodingStyle Chapter 6 Well, why is this change an improvement? Yes, it makes an old file follow the new(er) Documentation/CodingStyl, but what exactly is the

[PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions

2015-05-02 Thread Fabian Frederick
EXPORT macro must be placed directly after functions. See Documentation/CodingStyle Chapter 6 Signed-off-by: Fabian Frederick --- drivers/pnp/driver.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c index 153a493..b690e6b

[PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions

2015-05-02 Thread Fabian Frederick
EXPORT macro must be placed directly after functions. See Documentation/CodingStyle Chapter 6 Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/pnp/driver.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c index