Re: [PATCH 1/1 linux-next] affs: add default case in switch

2015-05-03 Thread Richard Weinberger
Am 03.05.2015 um 20:38 schrieb Fabian Frederick: > > >> On 03 May 2015 at 20:23 Richard Weinberger wrote: >> >> >> Am 03.05.2015 um 20:15 schrieb Fabian Frederick: If the code can be reached you need to take a proper action of not the warning is bogus. >>> >>> As far as I understand,

Re: [PATCH 1/1 linux-next] affs: add default case in switch

2015-05-03 Thread Fabian Frederick
> On 03 May 2015 at 20:23 Richard Weinberger wrote: > > > Am 03.05.2015 um 20:15 schrieb Fabian Frederick: > >> If the code can be reached you need to take a proper action of not the > >> warning is bogus. > > > > As far as I understand, switch in affs_lookup() only updates inode number > >

Re: [PATCH 1/1 linux-next] affs: add default case in switch

2015-05-03 Thread Richard Weinberger
Am 03.05.2015 um 20:15 schrieb Fabian Frederick: >> If the code can be reached you need to take a proper action of not the >> warning is bogus. > > As far as I understand, switch in affs_lookup() only updates inode number when > it's a link so we can simply add default:break to silence gcc

Re: [PATCH 1/1 linux-next] affs: add default case in switch

2015-05-03 Thread Fabian Frederick
> On 03 May 2015 at 16:51 Richard Weinberger > wrote: > > > On Sat, May 2, 2015 at 8:56 PM, Fabian Frederick wrote: > > Fix gcc -Wswitch-default warnings > > > > Cc: Andrew Morton > > Signed-off-by: Fabian Frederick > > --- > >  fs/affs/inode.c | 2 ++ > >  fs/affs/namei.c | 3 +++ > >  2

Re: [PATCH 1/1 linux-next] affs: add default case in switch

2015-05-03 Thread Richard Weinberger
On Sat, May 2, 2015 at 8:56 PM, Fabian Frederick wrote: > Fix gcc -Wswitch-default warnings > > Cc: Andrew Morton > Signed-off-by: Fabian Frederick > --- > fs/affs/inode.c | 2 ++ > fs/affs/namei.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/fs/affs/inode.c b/fs/affs/inode.c >

Re: [PATCH 1/1 linux-next] affs: add default case in switch

2015-05-03 Thread Richard Weinberger
On Sat, May 2, 2015 at 8:56 PM, Fabian Frederick f...@skynet.be wrote: Fix gcc -Wswitch-default warnings Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/inode.c | 2 ++ fs/affs/namei.c | 3 +++ 2 files changed, 5 insertions(+) diff

Re: [PATCH 1/1 linux-next] affs: add default case in switch

2015-05-03 Thread Fabian Frederick
On 03 May 2015 at 20:23 Richard Weinberger rich...@nod.at wrote: Am 03.05.2015 um 20:15 schrieb Fabian Frederick: If the code can be reached you need to take a proper action of not the warning is bogus. As far as I understand, switch in affs_lookup() only updates inode number when

Re: [PATCH 1/1 linux-next] affs: add default case in switch

2015-05-03 Thread Fabian Frederick
On 03 May 2015 at 16:51 Richard Weinberger richard.weinber...@gmail.com wrote: On Sat, May 2, 2015 at 8:56 PM, Fabian Frederick f...@skynet.be wrote: Fix gcc -Wswitch-default warnings Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be ---  

Re: [PATCH 1/1 linux-next] affs: add default case in switch

2015-05-03 Thread Richard Weinberger
Am 03.05.2015 um 20:15 schrieb Fabian Frederick: If the code can be reached you need to take a proper action of not the warning is bogus. As far as I understand, switch in affs_lookup() only updates inode number when it's a link so we can simply add default:break to silence gcc warning or

Re: [PATCH 1/1 linux-next] affs: add default case in switch

2015-05-03 Thread Richard Weinberger
Am 03.05.2015 um 20:38 schrieb Fabian Frederick: On 03 May 2015 at 20:23 Richard Weinberger rich...@nod.at wrote: Am 03.05.2015 um 20:15 schrieb Fabian Frederick: If the code can be reached you need to take a proper action of not the warning is bogus. As far as I understand, switch in

[PATCH 1/1 linux-next] affs: add default case in switch

2015-05-02 Thread Fabian Frederick
Fix gcc -Wswitch-default warnings Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/inode.c | 2 ++ fs/affs/namei.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/fs/affs/inode.c b/fs/affs/inode.c index 1734950..623398e 100644 --- a/fs/affs/inode.c +++ b/fs/affs/inode.c @@

[PATCH 1/1 linux-next] affs: add default case in switch

2015-05-02 Thread Fabian Frederick
Fix gcc -Wswitch-default warnings Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/inode.c | 2 ++ fs/affs/namei.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/fs/affs/inode.c b/fs/affs/inode.c index 1734950..623398e 100644 ---