Re: [PATCH 1/1 linux-next] ceph: fix bool assignments

2014-10-10 Thread Fabian Frederick
> On 10 October 2014 at 10:24 Ilya Dryomov wrote: > > > On Fri, Oct 10, 2014 at 4:41 AM, Dan Mick wrote: > > > > > > On 10/09/2014 02:16 PM, Fabian Frederick wrote: > >> Fix some coccinelle warnings: > >> fs/ceph/caps.c:2400:6-10: WARNING: Assignment of bool to 0/1 > > > > > >> -     bool wake

Re: [PATCH 1/1 linux-next] ceph: fix bool assignments

2014-10-10 Thread Ilya Dryomov
On Fri, Oct 10, 2014 at 4:41 AM, Dan Mick wrote: > > > On 10/09/2014 02:16 PM, Fabian Frederick wrote: >> Fix some coccinelle warnings: >> fs/ceph/caps.c:2400:6-10: WARNING: Assignment of bool to 0/1 > > >> - bool wake = 0; >> + bool wake = false; > > FWIW, that message is backwards: it sh

Re: [PATCH 1/1 linux-next] ceph: fix bool assignments

2014-10-10 Thread Ilya Dryomov
On Fri, Oct 10, 2014 at 1:16 AM, Fabian Frederick wrote: > Fix some coccinelle warnings: > fs/ceph/caps.c:2400:6-10: WARNING: Assignment of bool to 0/1 > fs/ceph/caps.c:2401:6-15: WARNING: Assignment of bool to 0/1 > fs/ceph/caps.c:2402:6-17: WARNING: Assignment of bool to 0/1 > fs/ceph/caps.c:240

Re: [PATCH 1/1 linux-next] ceph: fix bool assignments

2014-10-09 Thread Dan Mick
On 10/09/2014 02:16 PM, Fabian Frederick wrote: > Fix some coccinelle warnings: > fs/ceph/caps.c:2400:6-10: WARNING: Assignment of bool to 0/1 > - bool wake = 0; > + bool wake = false; FWIW, that message is backwards: it should say "WARNING: Assignment of 0/1 to bool" (I know, it's a c

[PATCH 1/1 linux-next] ceph: fix bool assignments

2014-10-09 Thread Fabian Frederick
Fix some coccinelle warnings: fs/ceph/caps.c:2400:6-10: WARNING: Assignment of bool to 0/1 fs/ceph/caps.c:2401:6-15: WARNING: Assignment of bool to 0/1 fs/ceph/caps.c:2402:6-17: WARNING: Assignment of bool to 0/1 fs/ceph/caps.c:2403:6-22: WARNING: Assignment of bool to 0/1 fs/ceph/caps.c:2404:6-22: