Re: [PATCH 1/1 linux-next] drm/nouveau: don't opencode IS_REACHABLE()

2016-11-14 Thread Jani Nikula
On Sat, 12 Nov 2016, Fabian Frederick wrote: > -#if defined(CONFIG_HWMON) || (defined(MODULE) && > defined(CONFIG_HWMON_MODULE)) > +#if IS_REACHABLE(CONFIG_HWMON) The changes seem to make sense per se, but I'd be interested in hearing the rationale for not expressing this

Re: [PATCH 1/1 linux-next] drm/nouveau: don't opencode IS_REACHABLE()

2016-11-14 Thread Jani Nikula
On Sat, 12 Nov 2016, Fabian Frederick wrote: > -#if defined(CONFIG_HWMON) || (defined(MODULE) && > defined(CONFIG_HWMON_MODULE)) > +#if IS_REACHABLE(CONFIG_HWMON) The changes seem to make sense per se, but I'd be interested in hearing the rationale for not expressing this dependency in terms of

[PATCH 1/1 linux-next] drm/nouveau: don't opencode IS_REACHABLE()

2016-11-12 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 6 +++--- drivers/gpu/drm/nouveau/nvkm/subdev/pci/agp.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c

[PATCH 1/1 linux-next] drm/nouveau: don't opencode IS_REACHABLE()

2016-11-12 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 6 +++--- drivers/gpu/drm/nouveau/nvkm/subdev/pci/agp.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c