Re: [PATCH 1/1 linux-next] exofs: convert simple_str to kstr

2015-04-30 Thread Fabian Frederick
> On 30 April 2015 at 09:55 Boaz Harrosh wrote: > > > On 04/29/2015 08:58 PM, Fabian Frederick wrote: > > replace obsolete function. > > > > Signed-off-by: Fabian Frederick > > Thanks. > ACK-by: Boaz Harrosh > > Are you pushing all these through some tree, or > You need that I push it? Maybe

Re: [PATCH 1/1 linux-next] exofs: convert simple_str to kstr

2015-04-30 Thread Alexey Dobriyan
On Thu, Apr 30, 2015 at 2:06 PM, Alexey Dobriyan wrote: >> case Opt_pid: >> + { >> + int rc; >> + >> if (0 == match_strlcpy(str, [0], sizeof(str))) >> return -EINVAL; >> - opts->pid = simple_strtoull(str, NULL, 0); >> + rc = kstrtoull(str, 0, >pid); >> + if (rc) >> + return rc; > >

Re: [PATCH 1/1 linux-next] exofs: convert simple_str to kstr

2015-04-30 Thread Alexey Dobriyan
> case Opt_pid: > + { > + int rc; > + > if (0 == match_strlcpy(str, [0], sizeof(str))) > return -EINVAL; > - opts->pid = simple_strtoull(str, NULL, 0); > + rc = kstrtoull(str, 0, >pid); > + if (rc) > + return rc; kstrto*() functions were designed for proc/sysfs/sysctl/debugfs/... files

Re: [PATCH 1/1 linux-next] exofs: convert simple_str to kstr

2015-04-30 Thread Boaz Harrosh
On 04/29/2015 08:58 PM, Fabian Frederick wrote: > replace obsolete function. > > Signed-off-by: Fabian Frederick Thanks. ACK-by: Boaz Harrosh Are you pushing all these through some tree, or You need that I push it? Maybe push all these changes through some central place, like Andrew's tree?

Re: [PATCH 1/1 linux-next] exofs: convert simple_str to kstr

2015-04-30 Thread Boaz Harrosh
On 04/29/2015 08:58 PM, Fabian Frederick wrote: replace obsolete function. Signed-off-by: Fabian Frederick f...@skynet.be Thanks. ACK-by: Boaz Harrosh o...@electrozaur.com Are you pushing all these through some tree, or You need that I push it? Maybe push all these changes through some

Re: [PATCH 1/1 linux-next] exofs: convert simple_str to kstr

2015-04-30 Thread Alexey Dobriyan
case Opt_pid: + { + int rc; + if (0 == match_strlcpy(str, args[0], sizeof(str))) return -EINVAL; - opts-pid = simple_strtoull(str, NULL, 0); + rc = kstrtoull(str, 0, opts-pid); + if (rc) + return rc; kstrto*() functions were designed for proc/sysfs/sysctl/debugfs/... files

Re: [PATCH 1/1 linux-next] exofs: convert simple_str to kstr

2015-04-30 Thread Alexey Dobriyan
On Thu, Apr 30, 2015 at 2:06 PM, Alexey Dobriyan adobri...@gmail.com wrote: case Opt_pid: + { + int rc; + if (0 == match_strlcpy(str, args[0], sizeof(str))) return -EINVAL; - opts-pid = simple_strtoull(str, NULL, 0); + rc = kstrtoull(str, 0, opts-pid); + if (rc) + return rc;

Re: [PATCH 1/1 linux-next] exofs: convert simple_str to kstr

2015-04-30 Thread Fabian Frederick
On 30 April 2015 at 09:55 Boaz Harrosh o...@electrozaur.com wrote: On 04/29/2015 08:58 PM, Fabian Frederick wrote: replace obsolete function. Signed-off-by: Fabian Frederick f...@skynet.be Thanks. ACK-by: Boaz Harrosh o...@electrozaur.com Are you pushing all these through some

[PATCH 1/1 linux-next] exofs: convert simple_str to kstr

2015-04-29 Thread Fabian Frederick
replace obsolete function. Signed-off-by: Fabian Frederick --- This is untested. fs/exofs/super.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/exofs/super.c b/fs/exofs/super.c index b795c56..b667f73 100644 --- a/fs/exofs/super.c +++ b/fs/exofs/super.c @@ -108,9

[PATCH 1/1 linux-next] exofs: convert simple_str to kstr

2015-04-29 Thread Fabian Frederick
replace obsolete function. Signed-off-by: Fabian Frederick f...@skynet.be --- This is untested. fs/exofs/super.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/exofs/super.c b/fs/exofs/super.c index b795c56..b667f73 100644 --- a/fs/exofs/super.c +++