Re: [PATCH 1/1 linux-next] fs/coda/upcall.c: remove UPARG flow control macro

2015-04-27 Thread Fabian Frederick
> On 27 April 2015 at 20:37 Jan Harkes wrote: > > > On Mon, Apr 27, 2015 at 07:23:06PM +0200, Fabian Frederick wrote: > > Move UPARG code to alloc_upcall() and test errors/return in callsites. > > This patch removes flow control in macros which must be avoided. > > (See

Re: [PATCH 1/1 linux-next] fs/coda/upcall.c: remove UPARG flow control macro

2015-04-27 Thread Jan Harkes
On Mon, Apr 27, 2015 at 07:23:06PM +0200, Fabian Frederick wrote: > Move UPARG code to alloc_upcall() and test errors/return in callsites. > This patch removes flow control in macros which must be avoided. > (See Documentation/CodingStyle) At first glance this is not a correct patch. UPARG

[PATCH 1/1 linux-next] fs/coda/upcall.c: remove UPARG flow control macro

2015-04-27 Thread Fabian Frederick
Move UPARG code to alloc_upcall() and test errors/return in callsites. This patch removes flow control in macros which must be avoided. (See Documentation/CodingStyle) Signed-off-by: Fabian Frederick --- This is untested. fs/coda/upcall.c | 107

Re: [PATCH 1/1 linux-next] fs/coda/upcall.c: remove UPARG flow control macro

2015-04-27 Thread Fabian Frederick
On 27 April 2015 at 20:37 Jan Harkes jahar...@cs.cmu.edu wrote: On Mon, Apr 27, 2015 at 07:23:06PM +0200, Fabian Frederick wrote: Move UPARG code to alloc_upcall() and test errors/return in callsites. This patch removes flow control in macros which must be avoided. (See

[PATCH 1/1 linux-next] fs/coda/upcall.c: remove UPARG flow control macro

2015-04-27 Thread Fabian Frederick
Move UPARG code to alloc_upcall() and test errors/return in callsites. This patch removes flow control in macros which must be avoided. (See Documentation/CodingStyle) Signed-off-by: Fabian Frederick f...@skynet.be --- This is untested. fs/coda/upcall.c | 107

Re: [PATCH 1/1 linux-next] fs/coda/upcall.c: remove UPARG flow control macro

2015-04-27 Thread Jan Harkes
On Mon, Apr 27, 2015 at 07:23:06PM +0200, Fabian Frederick wrote: Move UPARG code to alloc_upcall() and test errors/return in callsites. This patch removes flow control in macros which must be avoided. (See Documentation/CodingStyle) At first glance this is not a correct patch. UPARG