Re: [Ocfs2-devel] [PATCH 1/1 linux-next] ocfs2: remove unnecessary sizeof(char)

2014-12-23 Thread Rasmus Villemoes
On Mon, Dec 22 2014, Andrew Morton wrote: > On Mon, 22 Dec 2014 20:05:09 +0100 Fabian Frederick wrote: > >> >> -replay_map = kzalloc(sizeof(struct ocfs2_replay_map) + >> - (osb->max_slots * sizeof(char)), GFP_KERNEL); >> +replay_map = kzalloc(sizeof(struct ocfs2

Re: [Ocfs2-devel] [PATCH 1/1 linux-next] ocfs2: remove unnecessary sizeof(char)

2014-12-22 Thread Andrew Morton
On Mon, 22 Dec 2014 20:05:09 +0100 Fabian Frederick wrote: > sizeof(char) is always 1. > > ... > > --- a/fs/ocfs2/journal.c > +++ b/fs/ocfs2/journal.c > @@ -129,8 +129,8 @@ int ocfs2_compute_replay_slots(struct ocfs2_super *osb) > if (osb->replay_map) > return 0; > > -

[PATCH 1/1 linux-next] ocfs2: remove unnecessary sizeof(char)

2014-12-22 Thread Fabian Frederick
sizeof(char) is always 1. Suggested-by: Joe Perches Signed-off-by: Fabian Frederick --- fs/ocfs2/journal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c index e238bbc..750597c 100644 --- a/fs/ocfs2/journal.c +++ b/fs/ocfs2/journa