Re: [PATCH 1/1 linux-next] scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning

2015-04-09 Thread Julia Lawall
On Thu, 9 Apr 2015, Fabian Frederick wrote: > if()/BUG conversion to BUG_ON must be avoided when there's side effect > in condition. The reason being BUG_ON won't execute condition when CONFIG_BUG > is not defined. > > Inspired-by: J. Bruce Fields > Suggested-by: Julia Lawall > Signed-off-by:

[PATCH 1/1 linux-next] scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning

2015-04-09 Thread Fabian Frederick
if()/BUG conversion to BUG_ON must be avoided when there's side effect in condition. The reason being BUG_ON won't execute condition when CONFIG_BUG is not defined. Inspired-by: J. Bruce Fields Suggested-by: Julia Lawall Signed-off-by: Fabian Frederick --- scripts/coccinelle/misc/bugon.cocci

Re: [PATCH 1/1 linux-next] scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning

2015-04-09 Thread Julia Lawall
On Thu, 9 Apr 2015, Fabian Frederick wrote: if()/BUG conversion to BUG_ON must be avoided when there's side effect in condition. The reason being BUG_ON won't execute condition when CONFIG_BUG is not defined. Inspired-by: J. Bruce Fields bfie...@fieldses.org Suggested-by: Julia Lawall

[PATCH 1/1 linux-next] scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning

2015-04-09 Thread Fabian Frederick
if()/BUG conversion to BUG_ON must be avoided when there's side effect in condition. The reason being BUG_ON won't execute condition when CONFIG_BUG is not defined. Inspired-by: J. Bruce Fields bfie...@fieldses.org Suggested-by: Julia Lawall julia.law...@lip6.fr Signed-off-by: Fabian Frederick